Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-10-31 18:46:07 +01:00
Code Issues Packages Projects Releases Activity

Remove unnecessary null check

Browse Source 
The function RevWalk#parseAny indeed never returns null. This check only
was there to satisfy the (therefore wrong) unit test.
This commit is contained in:
René Pfeuffer
2020-10-12 19:02:28 +02:00
parent befd50eeef
commit c5f8d975a3
2 changed files with 28 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
scm-plugins/scm-git-plugin/src/main/java/sonia/scm/repository/api/GitHookTagProvider.java
View File

@@ -92,21 +92,19 @@ public class GitHookTagProvider implements HookTagProvider {
}
private Tag createTagFromNewId(RevWalk revWalk, ReceiveCommand rc, String tag) throws IOException {
final ObjectId newId = rc.getNewId();
ObjectId newId = rc.getNewId();
return new Tag(tag, getId(unpeelTag(revWalk, newId)), GitUtil.getTagTime(revWalk, newId));
}
private Tag createTagFromOldId(RevWalk revWalk, ReceiveCommand rc, String tag) throws IOException {
final ObjectId oldId = rc.getOldId();
ObjectId oldId = rc.getOldId();
return new Tag(tag, getId(unpeelTag(revWalk, oldId)), GitUtil.getTagTime(revWalk, oldId));
}
public ObjectId unpeelTag(RevWalk revWalk, ObjectId oldId) throws IOException {
final RevObject revObject = revWalk.parseAny(oldId);
RevObject revObject = revWalk.parseAny(oldId);
if (revObject instanceof RevTag) {
return unpeelTag(revWalk, ((RevTag) revObject).getObject());
} else if (revObject == null) {
return oldId;
} else {
return revObject;
}