Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-13 17:05:43 +01:00
Code Issues Packages Projects Releases Activity

fix review findings

Browse Source
This commit is contained in:
Eduard Heimbuch
2020-08-11 10:34:29 +02:00
parent a46d8c4749
commit c1cfff603b
63 changed files with 578 additions and 494 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
scm-ui/ui-webapp/src/users/components/table/Details.tsx
View File

@@ -24,7 +24,13 @@
import React from "react";
import { WithTranslation, withTranslation } from "react-i18next";
import { User } from "@scm-manager/ui-types";
import { Checkbox, DateFromNow, MailLink } from "@scm-manager/ui-components";
import {
Checkbox,
DateFromNow,
MailLink,
createAttributesForTesting,
replaceSpacesInTestId
} from "@scm-manager/ui-components";
type Props = WithTranslation & {
user: User;
@@ -38,11 +44,11 @@ class Details extends React.Component<Props> {
<tbody>
<tr>
<th>{t("user.name")}</th>
<td>{user.name}</td>
<td {...createAttributesForTesting(replaceSpacesInTestId(user.name))}>{user.name}</td>
</tr>
<tr>
<th>{t("user.displayName")}</th>
<td>{user.displayName}</td>
<td {...createAttributesForTesting(replaceSpacesInTestId(user.displayName))}>{user.displayName}</td>
</tr>
<tr>
<th>{t("user.mail")}</th>

8
scm-ui/ui-webapp/src/users/components/table/UserRow.tsx
View File

@@ -25,7 +25,7 @@ import React from "react";
import { WithTranslation, withTranslation } from "react-i18next";
import { Link } from "react-router-dom";
import { User } from "@scm-manager/ui-types";
import { Icon } from "@scm-manager/ui-components";
import { Icon, createAttributesForTesting } from "@scm-manager/ui-components";
type Props = WithTranslation & {
user: User;
@@ -33,7 +33,11 @@ type Props = WithTranslation & {
class UserRow extends React.Component<Props> {
renderLink(to: string, label: string) {
return <Link to={to}>{label}</Link>;
return (
<Link to={to} {...createAttributesForTesting(label)}>
{label}
</Link>
);
}
render() {