fix review findings

scm-ui/ui-webapp/src/permissions/components/PermissionCheckbox.tsx

@@ -45,6 +45,9 @@ class PermissionCheckbox extends React.Component<Props> {
       ? t("verbs.repository." + name + ".description")
       : this.translateOrDefault("permissions." + key + ".description", t("permissions.unknown"));
 
+    // @ts-ignore we have to use the label here because cypress gets confused with asterix and dots
+    const testId = label.replaceAll(" ", "-").toLowerCase();
+
     return (
       <Checkbox
         key={name}
@@ -54,6 +57,7 @@ class PermissionCheckbox extends React.Component<Props> {
         checked={checked}
         onChange={onChange}
         disabled={disabled}
+        testId={testId}
       />
     );
   }

scm-ui/ui-webapp/src/permissions/components/SetPermissions.tsx

@@ -142,6 +142,7 @@ class SetPermissions extends React.Component<Props, State> {
               disabled={!this.state.permissionsChanged}
               loading={loading}
               label={t("setPermissions.button")}
+              testId="set-permissions-button"
             />
           }
         />