Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-10 23:45:44 +01:00
Code Issues Packages Projects Releases Activity

implemented optional dependencies

Browse Source 
Plugin authors could now define optional dependencies to other plugins in their pom.
Extensions which are using classes from optional dependencies must specify this
with the "requires" attribute of the extension annotation.
Extensions with "requires" attribute are not installed if one of the specified plugins,
is not installed.
This commit is contained in:
Sebastian Sdorra
2020-01-08 14:27:11 +01:00
parent 3244e552a9
commit c1aa4af6e0
14 changed files with 262 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
scm-webapp/src/main/java/sonia/scm/plugin/PluginTree.java
View File

@@ -35,15 +35,13 @@ package sonia.scm.plugin;
import com.google.common.collect.Lists;
import com.google.common.collect.Ordering;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
//~--- JDK imports ------------------------------------------------------------
import java.util.Arrays;
import java.util.List;
import java.util.Set;
//~--- JDK imports ------------------------------------------------------------
/**
*
@@ -104,9 +102,7 @@ public final class PluginTree
if ((condition == null) || condition.isSupported())
{
Set<String> dependencies = plugin.getDependencies();
if ((dependencies == null) || dependencies.isEmpty())
if (plugin.getDependencies().isEmpty() && plugin.getOptionalDependencies().isEmpty())
{
rootNodes.add(new PluginNode(smp));
}
@@ -170,6 +166,20 @@ public final class PluginTree
//J+
}
}
boolean rootNode = smp.getPlugin().getDependencies().isEmpty();
for (String dependency : smp.getPlugin().getOptionalDependencies()) {
if (appendNode(rootNodes, child, dependency)) {
rootNode = false;
} else {
logger.info("optional dependency {} of {} is not installed", dependency, child.getId());
}
}
if (rootNode) {
logger.info("could not find optional dependencies of {}, append it as root node", child.getId());
rootNodes.add(new PluginNode(smp));
}
}
/**
@@ -212,7 +222,18 @@ public final class PluginTree
@Override
public String toString() {
return "plugin tree: " + rootNodes.toString();
StringBuilder buffer = new StringBuilder();
for (PluginNode node : rootNodes) {
append(buffer, "", node);
}
return buffer.toString();
}
private void append(StringBuilder buffer, String indent, PluginNode node) {
buffer.append(indent).append("+- ").append(node.getId()).append("\n");
for (PluginNode child : node.getChildren()) {
append(buffer, indent + " ", child);
}
}
//~--- fields ---------------------------------------------------------------