allow linting of .js files and added tests for eslint config

scm-ui/eslint-config/package.json

@@ -2,16 +2,19 @@
   "name": "@scm-manager/eslint-config",
   "version": "2.0.0",
   "description": "ESLint configuration for scm-manager and its plugins",
-  "main": "index.js",
+  "main": "src/index.js",
   "author": "Sebastian Sdorra <s.sdorra@gmail.com>",
   "license": "MIT",
   "private": false,
+  "scripts": {
+    "test": "jest"
+  },
   "prettier": "@scm-manager/prettier-config",
   "dependencies": {
     "@typescript-eslint/eslint-plugin": "^2.12.0",
     "@typescript-eslint/parser": "^2.12.0",
     "babel-eslint": "^10.0.3",
-    "eslint": "^6.5.1",
+    "eslint": "^7.2.0",
     "eslint-config-prettier": "^6.4.0",
     "eslint-config-react-app": "^5.0.2",
     "eslint-plugin-flowtype": "^4.3.0",
@@ -21,6 +24,9 @@
     "eslint-plugin-react": "^7.16.0",
     "eslint-plugin-react-hooks": "^2.1.2"
   },
+  "devDependencies": {
+    "jest": "^26.0.1"
+  },
   "publishConfig": {
     "access": "public"
   }

scm-ui/eslint-config/src/__resources__/Node.js

@@ -0,0 +1,2 @@
+var path = require('path')
+console.log('we do not use path')

scm-ui/eslint-config/src/__resources__/Typescript.ts

@@ -0,0 +1,2 @@
+const path = require('path');
+console.log("from typscript");

scm-ui/eslint-config/src/__resources__/TypescriptWithJsx.tsx

@@ -0,0 +1 @@
+console.log('from Sample.tsx')

scm-ui/eslint-config/src/index.js

@@ -21,8 +21,13 @@
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
  * SOFTWARE.
  */
+
 module.exports = {
   parser: "@typescript-eslint/parser",
+  env: {
+    node: false,
+    browser: true
+  },
   extends: ["react-app", "plugin:prettier/recommended", "plugin:@typescript-eslint/recommended"],
   rules: {
     "prettier/prettier": "warn",
@@ -32,5 +37,14 @@ module.exports = {
     "@typescript-eslint/explicit-function-return-type": "off",
     "@typescript-eslint/ban-ts-ignore": "warn",
     "no-console": "error"
-  }
+  },
+  overrides: [
+    {
+      files: ["*.js"],
+      env: {
+        node: true,
+        browser: false
+      }
+    }
+  ]
 };

scm-ui/eslint-config/src/index.test.js

@@ -0,0 +1,44 @@
+const { ESLint } = require("eslint");
+const path = require("path");
+
+describe("should lint files", () => {
+  const eslint = new ESLint();
+  const resource = path.join(__dirname, "__resources__");
+
+  const lint = async file => {
+    const results = await eslint.lintFiles([path.join(resource, file)]);
+
+    const messages = results[0].messages;
+
+    const warnings = messages.filter(m => m.severity === 1).map(m => m.ruleId);
+    const errors = messages.filter(m => m.severity === 2).map(m => m.ruleId);
+    return {
+      errors,
+      warnings
+    };
+  };
+
+  const expectContains = (results, ...ids) => {
+    for (const id of ids) {
+      expect(results).toContain(id);
+    }
+  }
+
+  it("should lint tsx files", async () => {
+    const { errors, warnings } = await lint("TypescriptWithJsx.tsx");
+    expectContains(errors, "no-console", "quotes", "semi");
+    expectContains(warnings, "prettier/prettier");
+  });
+
+  it("should lint js files", async () => {
+    const { errors, warnings } = await lint("Node.js");
+    expectContains(errors, "no-var", "no-console", "quotes", "semi");
+    expectContains(warnings, "prettier/prettier");
+  });
+
+  it("should lint ts files", async () => {
+    const { errors, warnings } = await lint("Typescript.ts");
+    expectContains(errors, "no-console", "quotes");
+    expectContains(warnings, "prettier/prettier");
+  });
+});