allow linting of .js files and added tests for eslint config

This commit is contained in:
Sebastian Sdorra
2020-06-15 22:01:16 +02:00
parent 1a190db34e
commit c10b588576
7 changed files with 1407 additions and 75 deletions

View File

@@ -0,0 +1,2 @@
var path = require('path')
console.log('we do not use path')

View File

@@ -0,0 +1,2 @@
const path = require('path');
console.log("from typscript");

View File

@@ -0,0 +1 @@
console.log('from Sample.tsx')

View File

@@ -0,0 +1,50 @@
/*
* MIT License
*
* Copyright (c) 2020-present Cloudogu GmbH and Contributors
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in all
* copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
* SOFTWARE.
*/
module.exports = {
parser: "@typescript-eslint/parser",
env: {
node: false,
browser: true
},
extends: ["react-app", "plugin:prettier/recommended", "plugin:@typescript-eslint/recommended"],
rules: {
"prettier/prettier": "warn",
semi: ["error", "always"],
quotes: ["error", "double", "avoid-escape"],
"jsx-a11y/href-no-hash": [0],
"@typescript-eslint/explicit-function-return-type": "off",
"@typescript-eslint/ban-ts-ignore": "warn",
"no-console": "error"
},
overrides: [
{
files: ["*.js"],
env: {
node: true,
browser: false
}
}
]
};

View File

@@ -0,0 +1,44 @@
const { ESLint } = require("eslint");
const path = require("path");
describe("should lint files", () => {
const eslint = new ESLint();
const resource = path.join(__dirname, "__resources__");
const lint = async file => {
const results = await eslint.lintFiles([path.join(resource, file)]);
const messages = results[0].messages;
const warnings = messages.filter(m => m.severity === 1).map(m => m.ruleId);
const errors = messages.filter(m => m.severity === 2).map(m => m.ruleId);
return {
errors,
warnings
};
};
const expectContains = (results, ...ids) => {
for (const id of ids) {
expect(results).toContain(id);
}
}
it("should lint tsx files", async () => {
const { errors, warnings } = await lint("TypescriptWithJsx.tsx");
expectContains(errors, "no-console", "quotes", "semi");
expectContains(warnings, "prettier/prettier");
});
it("should lint js files", async () => {
const { errors, warnings } = await lint("Node.js");
expectContains(errors, "no-var", "no-console", "quotes", "semi");
expectContains(warnings, "prettier/prettier");
});
it("should lint ts files", async () => {
const { errors, warnings } = await lint("Typescript.ts");
expectContains(errors, "no-console", "quotes");
expectContains(warnings, "prettier/prettier");
});
});