Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-13 17:05:43 +01:00
Code Issues Packages Projects Releases Activity

fix sonar issue squid:S1989: Exceptions should not be thrown from servlet methods

Browse Source
This commit is contained in:
Sebastian Sdorra
2019-06-13 12:03:02 +02:00
parent 8a2573764f
commit bc8c89cbf8
2 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
scm-webapp/src/main/java/sonia/scm/boot/StaticResourceServlet.java
View File

@@ -2,7 +2,8 @@ package sonia.scm.boot;
import com.github.sdorra.webresources.CacheControl;
import com.github.sdorra.webresources.WebResourceSender;
import com.google.common.annotations.VisibleForTesting;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import sonia.scm.util.HttpUtil;
import javax.inject.Singleton;
@@ -16,6 +17,8 @@ import java.net.URL;
@Singleton
public class StaticResourceServlet extends HttpServlet {
private static final Logger LOG = LoggerFactory.getLogger(StaticResourceServlet.class);
private final WebResourceSender sender = WebResourceSender.create()
.withGZIP()
.withGZIPMinLength(512)
@@ -23,12 +26,17 @@ public class StaticResourceServlet extends HttpServlet {
.withCacheControl(CacheControl.create().noCache());
@Override
protected void doGet(HttpServletRequest request, HttpServletResponse response) throws IOException {
URL resource = createResourceUrlFromRequest(request);
if (resource != null) {
sender.resource(resource).get(request, response);
} else {
response.setStatus(HttpServletResponse.SC_NOT_FOUND);
protected void doGet(HttpServletRequest request, HttpServletResponse response) {
try {
URL resource = createResourceUrlFromRequest(request);
if (resource != null) {
sender.resource(resource).get(request, response);
} else {
response.setStatus(HttpServletResponse.SC_NOT_FOUND);
}
} catch (IOException ex) {
LOG.warn("failed to servce resource", ex);
response.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
}
}