do not forward close button but close function as button is always the same

This commit is contained in:
Maren Süwer
2019-02-01 10:43:11 +01:00
parent 73260f0072
commit ba971beea3
3 changed files with 9 additions and 15 deletions

View File

@@ -29,13 +29,6 @@ class ConfirmAlert extends React.Component<Props> {
render() { render() {
const { title, message, buttons } = this.props; const { title, message, buttons } = this.props;
const closeButton = (
<button
className="delete"
aria-label="close"
onClick={() => this.close()}
/>
);
const body= ( const body= (
<> <>
{message} {message}
@@ -54,7 +47,7 @@ class ConfirmAlert extends React.Component<Props> {
return ( return (
<Modal title={title} closeButton={closeButton} body={body} active={true}/> <Modal title={title} closeFunction={() => this.close()} body={body} active={true}/>
); );
} }
} }

View File

@@ -5,7 +5,7 @@ import injectSheet from "react-jss";
type Props = { type Props = {
title: string, title: string,
closeButton: any, closeFunction: () => void,
body: any, body: any,
active: boolean, active: boolean,
classes: any classes: any
@@ -24,7 +24,7 @@ const styles = {
class Modal extends React.Component<Props> { class Modal extends React.Component<Props> {
render() { render() {
const { title, closeButton, body, active, classes } = this.props; const { title, closeFunction, body, active, classes } = this.props;
const isActive = active ? "is-active" : null; const isActive = active ? "is-active" : null;
@@ -40,7 +40,11 @@ class Modal extends React.Component<Props> {
<p className="modal-card-title"> <p className="modal-card-title">
{title} {title}
</p> </p>
{closeButton} <button
className="delete"
aria-label="close"
onClick={closeFunction}
/>
</header> </header>
<section className="modal-card-body"> <section className="modal-card-body">
{body} {body}

View File

@@ -50,9 +50,6 @@ class AdvancedPermissionsDialog extends React.Component<Props, State> {
<SubmitButton label={t("permission.advanced.dialog.submit")} /> <SubmitButton label={t("permission.advanced.dialog.submit")} />
) : null; ) : null;
const closeButton = (
<button className="delete" aria-label="close" onClick={() => onClose()} />
);
const body = ( const body = (
<> <>
@@ -70,7 +67,7 @@ class AdvancedPermissionsDialog extends React.Component<Props, State> {
return ( return (
<Modal <Modal
title={t("permission.advanced.dialog.title")} title={t("permission.advanced.dialog.title")}
closeButton={closeButton} closeFunction={() => onClose()}
body={body} body={body}
active={true} active={true}
/> />