use default type of user manager for default authentication

This commit is contained in:
Sebastian Sdorra
2012-03-18 17:17:39 +01:00
parent 6b93714ab9
commit b979c2d438
3 changed files with 13 additions and 15 deletions

View File

@@ -57,7 +57,7 @@ import sonia.scm.security.EncryptionHandler;
import sonia.scm.user.UserListener;
import sonia.scm.web.security.AuthenticationHandler;
import sonia.scm.web.security.AuthenticationListener;
import sonia.scm.web.security.XmlAuthenticationHandler;
import sonia.scm.web.security.DefaultAuthenticationHandler;
//~--- JDK imports ------------------------------------------------------------
@@ -134,7 +134,7 @@ public class BindingExtensionProcessor implements ExtensionProcessor
Multibinder<RepositoryRequestListener> repositoryRequestListenerBinder =
Multibinder.newSetBinder(binder, RepositoryRequestListener.class);
authenticators.addBinding().to(XmlAuthenticationHandler.class);
authenticators.addBinding().to(DefaultAuthenticationHandler.class);
for (Class extensionClass : extensions)
{

View File

@@ -58,18 +58,15 @@ import javax.servlet.http.HttpServletResponse;
* @author Sebastian Sdorra
*/
@Singleton
public class XmlAuthenticationHandler implements AuthenticationHandler
public class DefaultAuthenticationHandler implements AuthenticationHandler
{
/** Field description */
public static final String NAME_DIRECTORY = "users";
/** Field description */
public static final String TYPE = "xml";
/** the logger for XmlAuthenticationHandler */
private static final Logger logger =
LoggerFactory.getLogger(XmlAuthenticationHandler.class);
LoggerFactory.getLogger(DefaultAuthenticationHandler.class);
//~--- constructors ---------------------------------------------------------
@@ -81,8 +78,8 @@ public class XmlAuthenticationHandler implements AuthenticationHandler
* @param encryptionHandler
*/
@Inject
public XmlAuthenticationHandler(UserManager userManager,
EncryptionHandler encryptionHandler)
public DefaultAuthenticationHandler(UserManager userManager,
EncryptionHandler encryptionHandler)
{
this.userManager = userManager;
this.encryptionHandler = encryptionHandler;
@@ -110,7 +107,7 @@ public class XmlAuthenticationHandler implements AuthenticationHandler
if (user != null)
{
if (TYPE.equals(user.getType()))
if (userManager.getDefaultType().equals(user.getType()))
{
result = authenticate(user, username, password);
}
@@ -118,7 +115,8 @@ public class XmlAuthenticationHandler implements AuthenticationHandler
{
if (logger.isDebugEnabled())
{
logger.debug("{} is not an xml user", username);
logger.debug("{} is not an {} user", username,
userManager.getDefaultType());
}
result = AuthenticationResult.NOT_FOUND;
@@ -174,7 +172,7 @@ public class XmlAuthenticationHandler implements AuthenticationHandler
@Override
public String getType()
{
return TYPE;
return userManager.getDefaultType();
}
//~--- methods --------------------------------------------------------------