From b91d9e6b6086a8d5450826748c80ba6056331f30 Mon Sep 17 00:00:00 2001 From: Sebastian Sdorra Date: Wed, 4 Nov 2020 08:55:23 +0100 Subject: [PATCH] Add exception class to failed span of AdvancedHttpClient --- .../main/java/sonia/scm/net/ahc/DefaultAdvancedHttpClient.java | 3 ++- .../java/sonia/scm/net/ahc/DefaultAdvancedHttpClientTest.java | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/scm-webapp/src/main/java/sonia/scm/net/ahc/DefaultAdvancedHttpClient.java b/scm-webapp/src/main/java/sonia/scm/net/ahc/DefaultAdvancedHttpClient.java index 8ef0a22862..3bdfacf50c 100644 --- a/scm-webapp/src/main/java/sonia/scm/net/ahc/DefaultAdvancedHttpClient.java +++ b/scm-webapp/src/main/java/sonia/scm/net/ahc/DefaultAdvancedHttpClient.java @@ -201,7 +201,8 @@ public class DefaultAdvancedHttpClient extends AdvancedHttpClient } return response; } catch (IOException ex) { - span.label("exception", ex.getMessage()); + span.label("exception", ex.getClass().getName()); + span.label("message", ex.getMessage()); span.failed(); throw ex; } diff --git a/scm-webapp/src/test/java/sonia/scm/net/ahc/DefaultAdvancedHttpClientTest.java b/scm-webapp/src/test/java/sonia/scm/net/ahc/DefaultAdvancedHttpClientTest.java index 24b857ea9e..2b8d5cb381 100644 --- a/scm-webapp/src/test/java/sonia/scm/net/ahc/DefaultAdvancedHttpClientTest.java +++ b/scm-webapp/src/test/java/sonia/scm/net/ahc/DefaultAdvancedHttpClientTest.java @@ -302,7 +302,8 @@ public class DefaultAdvancedHttpClientTest verify(tracer).span("failures"); verify(span).label("url", "http://failing.host"); verify(span).label("method", "DELETE"); - verify(span).label("exception", "failed"); + verify(span).label("exception", IOException.class.getName()); + verify(span).label("message", "failed"); verify(span).failed(); verify(span).close(); }