Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-12 16:35:45 +01:00
Code Issues Packages Projects Releases Activity

append optional dependencies to webapp dto

Browse Source
This commit is contained in:
Konstantin Schaper
2020-07-22 09:55:57 +02:00
parent b51ddae59d
commit b3d5f930ea
3 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
scm-webapp/src/main/java/sonia/scm/api/v2/resources/PluginDto.java
View File

@@ -53,6 +53,7 @@ public class PluginDto extends HalRepresentation {
private Boolean core; private Boolean core;
private Boolean markedForUninstall; private Boolean markedForUninstall;
private Set<String> dependencies; private Set<String> dependencies;
private Set<String> optionalDependencies;
public PluginDto(Links links) { public PluginDto(Links links) {
add(links); add(links);

1
scm-webapp/src/main/java/sonia/scm/api/v2/resources/PluginDtoMapper.java
View File

@@ -68,6 +68,7 @@ public abstract class PluginDtoMapper {
private void map(PluginDto dto, Plugin plugin) { private void map(PluginDto dto, Plugin plugin) {
dto.setDependencies(plugin.getDescriptor().getDependencies()); dto.setDependencies(plugin.getDescriptor().getDependencies());
dto.setOptionalDependencies(plugin.getDescriptor().getOptionalDependencies());
map(plugin.getDescriptor().getInformation(), dto); map(plugin.getDescriptor().getInformation(), dto);
if (dto.getCategory() == null) { if (dto.getCategory() == null) {
dto.setCategory("Miscellaneous"); dto.setCategory("Miscellaneous");

9
scm-webapp/src/test/java/sonia/scm/api/v2/resources/PluginDtoMapperTest.java
View File

@@ -164,6 +164,15 @@ class PluginDtoMapperTest {
assertThat(dto.getDependencies()).containsOnly("one", "two"); assertThat(dto.getDependencies()).containsOnly("one", "two");
} }
@Test
void shouldAppendOptionalDependencies() {
AvailablePlugin plugin = createAvailable(createPluginInformation());
when(plugin.getDescriptor().getOptionalDependencies()).thenReturn(ImmutableSet.of("one", "two"));
PluginDto dto = mapper.mapAvailable(plugin);
assertThat(dto.getOptionalDependencies()).containsOnly("one", "two");
}
@Test @Test
void shouldAppendUninstallLink() { void shouldAppendUninstallLink() {
when(subject.isPermitted("plugin:write")).thenReturn(true); when(subject.isPermitted("plugin:write")).thenReturn(true);