Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-12 16:35:45 +01:00
Code Issues Packages Projects Releases Activity

Remove not used functions

Browse Source 
Equals and hashCode are not used, yet. Therefore we have no idea, how
they should be implemented at all. So they should not be implemented,
yet.

Further they are polluting the test coverage.
This commit is contained in:
René Pfeuffer
2018-06-27 15:00:52 +02:00
parent c5cafb8b6b
commit afd4b06b61
4 changed files with 12 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
scm-webapp/src/main/java/sonia/scm/api/v2/resources/CollectionDto.java
View File

@@ -3,10 +3,10 @@ package sonia.scm.api.v2.resources;
import de.otto.edison.hal.Embedded; import de.otto.edison.hal.Embedded;
import de.otto.edison.hal.HalRepresentation; import de.otto.edison.hal.HalRepresentation;
import de.otto.edison.hal.Links; import de.otto.edison.hal.Links;
import lombok.Data; import lombok.Getter;
import lombok.EqualsAndHashCode; import lombok.Setter;
@Data @EqualsAndHashCode(callSuper = false) @Getter @Setter
class CollectionDto extends HalRepresentation { class CollectionDto extends HalRepresentation {
private int page; private int page;

6
scm-webapp/src/main/java/sonia/scm/api/v2/resources/GroupDto.java
View File

@@ -3,16 +3,16 @@ package sonia.scm.api.v2.resources;
import com.fasterxml.jackson.annotation.JsonInclude; import com.fasterxml.jackson.annotation.JsonInclude;
import de.otto.edison.hal.HalRepresentation; import de.otto.edison.hal.HalRepresentation;
import de.otto.edison.hal.Links; import de.otto.edison.hal.Links;
import lombok.Data; import lombok.Getter;
import lombok.EqualsAndHashCode;
import lombok.NoArgsConstructor; import lombok.NoArgsConstructor;
import lombok.Setter;
import java.time.Instant; import java.time.Instant;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.Optional; import java.util.Optional;
@Data @NoArgsConstructor @EqualsAndHashCode(callSuper = true) @Getter @Setter @NoArgsConstructor
public class GroupDto extends HalRepresentation { public class GroupDto extends HalRepresentation {
private Instant creationDate; private Instant creationDate;

7
scm-webapp/src/main/java/sonia/scm/api/v2/resources/MemberDto.java
View File

@@ -3,12 +3,11 @@ package sonia.scm.api.v2.resources;
import de.otto.edison.hal.HalRepresentation; import de.otto.edison.hal.HalRepresentation;
import de.otto.edison.hal.Links; import de.otto.edison.hal.Links;
import lombok.AllArgsConstructor; import lombok.AllArgsConstructor;
import lombok.Data; import lombok.Getter;
import lombok.EqualsAndHashCode;
import lombok.NoArgsConstructor; import lombok.NoArgsConstructor;
import lombok.Setter;
@NoArgsConstructor @AllArgsConstructor @NoArgsConstructor @AllArgsConstructor @Getter @Setter
@Data @EqualsAndHashCode(callSuper = false)
public class MemberDto extends HalRepresentation { public class MemberDto extends HalRepresentation {
private String name; private String name;

8
scm-webapp/src/main/java/sonia/scm/api/v2/resources/UserDto.java
View File

@@ -3,17 +3,15 @@ package sonia.scm.api.v2.resources;
import com.fasterxml.jackson.annotation.JsonInclude; import com.fasterxml.jackson.annotation.JsonInclude;
import de.otto.edison.hal.HalRepresentation; import de.otto.edison.hal.HalRepresentation;
import de.otto.edison.hal.Links; import de.otto.edison.hal.Links;
import lombok.AllArgsConstructor; import lombok.Getter;
import lombok.Data;
import lombok.EqualsAndHashCode;
import lombok.NoArgsConstructor; import lombok.NoArgsConstructor;
import lombok.Setter;
import java.time.Instant; import java.time.Instant;
import java.util.Map; import java.util.Map;
import java.util.Optional; import java.util.Optional;
@AllArgsConstructor @NoArgsConstructor @NoArgsConstructor @Getter @Setter
@Data @EqualsAndHashCode(callSuper = false)
public class UserDto extends HalRepresentation { public class UserDto extends HalRepresentation {
private boolean active; private boolean active;
private boolean admin; private boolean admin;