merge with branch 1.x

scm-plugins/scm-git-plugin/src/test/java/sonia/scm/repository/GitRepositoryPathMatcherTest.java

@@ -0,0 +1,62 @@
+/**
+ * Copyright (c) 2010, Sebastian Sdorra
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright notice,
+ *    this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright notice,
+ *    this list of conditions and the following disclaimer in the documentation
+ *    and/or other materials provided with the distribution.
+ * 3. Neither the name of SCM-Manager; nor the names of its
+ *    contributors may be used to endorse or promote products derived from this
+ *    software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * http://bitbucket.org/sdorra/scm-manager
+ *
+ */
+package sonia.scm.repository;
+
+import org.junit.Test;
+import static org.junit.Assert.*;
+
+/**
+ * Unit tests for {@link GitRepositoryPathMatcher}.
+ * 
+ * @author Sebastian Sdorra
+ * @since 1.54
+ */
+public class GitRepositoryPathMatcherTest {
+
+  private final GitRepositoryPathMatcher pathMatcher = new GitRepositoryPathMatcher();
+
+  @Test
+  public void testIsPathMatching() {
+    assertFalse(pathMatcher.isPathMatching(repository("my-repo"), "my-repoo"));
+    assertFalse(pathMatcher.isPathMatching(repository("my"), "my-repo"));
+    assertFalse(pathMatcher.isPathMatching(repository("my"), "my-repo/with/path"));
+    
+    assertTrue(pathMatcher.isPathMatching(repository("my-repo"), "my-repo"));
+    assertTrue(pathMatcher.isPathMatching(repository("my-repo"), "my-repo.git"));
+    assertTrue(pathMatcher.isPathMatching(repository("my-repo"), "my-repo/with/path"));
+    assertTrue(pathMatcher.isPathMatching(repository("my-repo"), "my-repo.git/with/path"));
+  }
+  
+  private Repository repository(String name) {
+    return new Repository(name, GitRepositoryHandler.TYPE_NAME, name);
+  }
+  
+}

scm-plugins/scm-git-plugin/src/test/java/sonia/scm/repository/GitUtilTest.java

@@ -35,15 +35,10 @@ package sonia.scm.repository;
 
 //~--- non-JDK imports --------------------------------------------------------
 
-import org.eclipse.jgit.api.Git;
-import org.eclipse.jgit.api.errors.GitAPIException;
-
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.rules.TemporaryFolder;
 
-import static org.hamcrest.Matchers.*;
-
 import static org.junit.Assert.*;
 
 import static org.mockito.Mockito.*;
@@ -52,8 +47,9 @@ import static org.mockito.Mockito.*;
 
 import java.io.File;
 import java.io.IOException;
+import javax.servlet.http.HttpServletRequest;
 
-import static org.junit.Assert.*;
+import sonia.scm.util.HttpUtil;
 
 /**
  * Unit tests for {@link GitUtil}.
@@ -125,9 +121,25 @@ public class GitUtilTest
     return repo;
   }
 
-  //~--- fields ---------------------------------------------------------------
-
   /** Field description */
   @Rule
   public TemporaryFolder temp = new TemporaryFolder();
+  
+  @Test
+  public void testIsGitClient() {
+    HttpServletRequest request = mockRequestWithUserAgent("Git/2.9.3");
+    assertTrue(GitUtil.isGitClient(request));
+    
+    request = mockRequestWithUserAgent("JGit/2.9.3");
+    assertTrue(GitUtil.isGitClient(request));
+    
+    request = mockRequestWithUserAgent("Mozilla/5.0 (Linux; Android 4.0.4; Galaxy Nexus Build/IMM76B) ...");
+    assertFalse(GitUtil.isGitClient(request));
+  }
+  
+  private HttpServletRequest mockRequestWithUserAgent(String userAgent) {
+    HttpServletRequest request = mock(HttpServletRequest.class);
+    when(request.getHeader(HttpUtil.HEADER_USERAGENT)).thenReturn(userAgent);    
+    return request;
+  }
 }

scm-plugins/scm-git-plugin/src/test/java/sonia/scm/repository/client/spi/GitRepositoryClientProvider.java

@@ -191,7 +191,7 @@ public class GitRepositoryClientProvider extends RepositoryClientProvider
 
   @Override
   public File getWorkingCopy() {
-    return git.getRepository().getDirectory();
+    return git.getRepository().getWorkTree();
   }
 
   //~--- fields ---------------------------------------------------------------

scm-plugins/scm-git-plugin/src/test/java/sonia/scm/web/GitPermissionFilterTest.java

@@ -0,0 +1,135 @@
+package sonia.scm.web;
+
+import com.google.common.base.Charsets;
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+import javax.servlet.ServletOutputStream;
+import org.junit.Test;
+
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+import static org.hamcrest.Matchers.*;
+import static org.junit.Assert.*;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import static org.mockito.Mockito.*;
+import org.mockito.runners.MockitoJUnitRunner;
+import sonia.scm.config.ScmConfiguration;
+import sonia.scm.repository.RepositoryProvider;
+import sonia.scm.util.HttpUtil;
+
+/**
+ * Unit tests for {@link GitPermissionFilter}.
+ * 
+ * Created by omilke on 19.05.2017.
+ */
+@RunWith(MockitoJUnitRunner.class)
+public class GitPermissionFilterTest {
+
+  @Mock
+  private RepositoryProvider repositoryProvider;
+  
+  private final GitPermissionFilter permissionFilter = new GitPermissionFilter(
+    new ScmConfiguration(), repositoryProvider
+  );
+  
+  @Mock
+  private HttpServletResponse response;
+  
+  @Test
+  public void testIsWriteRequest() {
+    HttpServletRequest request = mockRequestWithMethodAndRequestURI("POST", "/scm/git/fanzy-project/git-receive-pack");
+    assertThat(permissionFilter.isWriteRequest(request), is(true));
+    
+    request = mockRequestWithMethodAndRequestURI("GET", "/scm/git/fanzy-project/info/refs?service=git-receive-pack");
+    assertThat(permissionFilter.isWriteRequest(request), is(true));
+    
+    request = mockRequestWithMethodAndRequestURI("GET", "/scm/git/fanzy-project/info/refs?service=some-other-service");
+    assertThat(permissionFilter.isWriteRequest(request), is(false));
+    
+    request = mockRequestWithMethodAndRequestURI(
+      "PUT", 
+      "/scm/git/git-lfs-demo.git/info/lfs/objects/8fcebeb5698230685f92028e560f8f1683ebc15ec82a620ffad5c12a3c19bdec"
+    );
+    assertThat(permissionFilter.isWriteRequest(request), is(true));
+    
+    request = mockRequestWithMethodAndRequestURI(
+      "GET", 
+      "/scm/git/git-lfs-demo.git/info/lfs/objects/8fcebeb5698230685f92028e560f8f1683ebc15ec82a620ffad5c12a3c19bdec"
+    );
+    assertThat(permissionFilter.isWriteRequest(request), is(false));
+    
+    request = mockRequestWithMethodAndRequestURI("POST", "/scm/git/git-lfs-demo.git/info/lfs/objects/batch");
+    assertThat(permissionFilter.isWriteRequest(request), is(false));
+  }
+
+  private HttpServletRequest mockRequestWithMethodAndRequestURI(String method, String requestURI) {
+    HttpServletRequest mock = mock(HttpServletRequest.class);
+
+    when(mock.getMethod()).thenReturn(method);
+    when(mock.getRequestURI()).thenReturn(requestURI);
+    when(mock.getContextPath()).thenReturn("/scm");
+
+    return mock;
+  }
+
+  @Test
+  public void testSendNotEnoughPrivilegesErrorAsBrowser() throws IOException {
+    HttpServletRequest request = mockGitReceivePackServiceRequest();
+    
+    permissionFilter.sendNotEnoughPrivilegesError(request, response);
+    
+    verify(response).sendError(HttpServletResponse.SC_FORBIDDEN);
+  }
+  
+  @Test
+  public void testSendNotEnoughPrivilegesErrorAsGitClient() throws IOException {
+    verifySendNotEnoughPrivilegesErrorAsGitClient("git/2.9.3");
+  }
+  
+  @Test
+  public void testSendNotEnoughPrivilegesErrorAsJGitClient() throws IOException {
+    verifySendNotEnoughPrivilegesErrorAsGitClient("JGit/4.2");
+  }
+  
+  private void verifySendNotEnoughPrivilegesErrorAsGitClient(String userAgent) throws IOException {
+    HttpServletRequest request = mockGitReceivePackServiceRequest();
+    when(request.getHeader(HttpUtil.HEADER_USERAGENT)).thenReturn(userAgent);
+    
+    CapturingServletOutputStream stream = new CapturingServletOutputStream();
+    when(response.getOutputStream()).thenReturn(stream);
+    
+    permissionFilter.sendNotEnoughPrivilegesError(request, response);
+    
+    verify(response).setStatus(HttpServletResponse.SC_OK);
+    assertThat(stream.toString(), containsString("privileges"));    
+  }
+  
+  private HttpServletRequest mockGitReceivePackServiceRequest() {
+    HttpServletRequest request = mockRequestWithMethodAndRequestURI("GET", "/git/info/refs");
+    when(request.getParameter("service")).thenReturn("git-receive-pack");
+    return request;
+  }
+  
+  private static class CapturingServletOutputStream extends ServletOutputStream {
+
+    private final ByteArrayOutputStream baos = new ByteArrayOutputStream();
+    
+    @Override
+    public void write(int b) throws IOException {
+      baos.write(b);
+    }
+
+    @Override
+    public void close() throws IOException {
+      baos.close();
+    }
+    
+    @Override
+    public String toString() {
+      return baos.toString();
+    }
+  }
+  
+}

scm-plugins/scm-git-plugin/src/test/java/sonia/scm/web/GitRepositoryResolverTest.java

@@ -0,0 +1,109 @@
+/**
+ * Copyright (c) 2010, Sebastian Sdorra
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright notice,
+ *    this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright notice,
+ *    this list of conditions and the following disclaimer in the documentation
+ *    and/or other materials provided with the distribution.
+ * 3. Neither the name of SCM-Manager; nor the names of its
+ *    contributors may be used to endorse or promote products derived from this
+ *    software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * http://bitbucket.org/sdorra/scm-manager
+ *
+ */
+package sonia.scm.web;
+
+import java.io.File;
+import java.io.IOException;
+import org.junit.Test;
+import static org.junit.Assert.*;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.rules.TemporaryFolder;
+import org.junit.runner.RunWith;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import static org.mockito.Mockito.*;
+import org.mockito.runners.MockitoJUnitRunner;
+import sonia.scm.repository.GitConfig;
+import sonia.scm.repository.GitRepositoryHandler;
+
+/**
+ * Unit tests for {@link GitRepositoryResolver}.
+ * 
+ * @author Sebastian Sdorra
+ */
+@RunWith(MockitoJUnitRunner.class)
+public class GitRepositoryResolverTest {
+  
+  @Rule
+  public TemporaryFolder temporaryFolder = new TemporaryFolder();
+  
+  private File parentDirectory;
+  
+  @Mock
+  private GitRepositoryHandler handler;
+  
+  @InjectMocks
+  private GitRepositoryResolver resolver;
+  
+  @Before
+  public void setUp() throws IOException {
+    parentDirectory = temporaryFolder.newFolder();
+    
+    GitConfig config = new GitConfig();
+    config.setRepositoryDirectory(parentDirectory);
+    
+    when(handler.getConfig()).thenReturn(config);
+  }
+  
+  @Test
+  public void testFindRepositoryWithoutDotGit() {
+    createRepositories("a", "ab");
+    
+    File directory = resolver.findRepository(parentDirectory, "a");
+    assertNotNull(directory);
+    assertEquals("a", directory.getName());
+    
+    directory = resolver.findRepository(parentDirectory, "ab");
+    assertNotNull(directory);
+    assertEquals("ab", directory.getName());
+  }
+  
+  @Test
+  public void testFindRepositoryWithDotGit() {
+    createRepositories("a", "ab");
+    
+    File directory = resolver.findRepository(parentDirectory, "a.git");
+    assertNotNull(directory);
+    assertEquals("a", directory.getName());
+    
+    directory = resolver.findRepository(parentDirectory, "ab.git");
+    assertNotNull(directory);
+    assertEquals("ab", directory.getName());
+  }
+  
+  private void createRepositories(String... names) {
+    for (String name : names) {
+      assertTrue(new File(parentDirectory, name).mkdirs());
+    }
+  }
+  
+}

scm-plugins/scm-git-plugin/src/test/java/sonia/scm/web/GitUserAgentProviderTest.java

@@ -33,51 +33,46 @@ package sonia.scm.web;
 
 //~--- non-JDK imports --------------------------------------------------------
 
-import com.google.common.base.Strings;
-
 import org.junit.Test;
 
 import static org.junit.Assert.*;
 
 //~--- JDK imports ------------------------------------------------------------
 
-import java.util.Locale;
-
 /**
- *
+ * Unit tests for {@link GitUserAgentProvider}.
+ * 
  * @author Sebastian Sdorra <sebastian.sdorra@triology.de>
  */
-public class GitUserAgentProviderTest
-{
+public class GitUserAgentProviderTest {
 
-  /**
-   * Method description
-   *
-   */
+  private final GitUserAgentProvider provider = new GitUserAgentProvider();
+  
   @Test
-  public void testParseUserAgent()
-  {
+  public void testParseUserAgent() {
     assertEquals(GitUserAgentProvider.GIT, parse("git/1.7.9.5"));
+    assertEquals(GitUserAgentProvider.JGIT, parse("jgit/4.5.2"));
+    assertEquals(GitUserAgentProvider.GIT_LFS, parse("git-lfs/2.0.1 (GitHub; windows amd64; go 1.8; git 678cdbd4)"));
     assertEquals(GitUserAgentProvider.MSYSGIT, parse("git/1.8.3.msysgit.0"));
     assertNull(parse("Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36"));
   }
 
-  /**
-   * Method description
-   *
-   *
-   * @param v
-   *
-   * @return
-   */
-  private UserAgent parse(String v)
-  {
-    return provider.parseUserAgent(
-      Strings.nullToEmpty(v).toLowerCase(Locale.ENGLISH));
+  @Test
+  public void testParseUserAgentCaseSensitive() {
+    assertEquals(GitUserAgentProvider.GIT, parse("Git/1.7.9.5"));
+  }
+  
+  @Test
+  public void testParseUserAgentWithEmptyValue() {
+    assertNull(parse(null));
+  }
+  
+  @Test
+  public void testParseUserAgentWithNullValue() {
+    assertNull(parse(null));
   }
 
-  //~--- fields ---------------------------------------------------------------
-
-  /** Field description */
-  private final GitUserAgentProvider provider = new GitUserAgentProvider();
+  private UserAgent parse(String v) {
+    return provider.parseUserAgent(v);
+  }
 }

scm-plugins/scm-git-plugin/src/test/java/sonia/scm/web/ScmGitServletTest.java

@@ -0,0 +1,26 @@
+package sonia.scm.web;
+
+import org.junit.Test;
+
+import static org.eclipse.jgit.lfs.lib.Constants.CONTENT_TYPE_GIT_LFS_JSON;
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.assertThat;
+
+/**
+ * Created by omilke on 11.05.2017.
+ */
+public class ScmGitServletTest {
+
+  @Test
+  public void isContentTypeMatches() throws Exception {
+
+    assertThat(ScmGitServlet.isLfsContentHeaderField("application/vnd.git-lfs+json", CONTENT_TYPE_GIT_LFS_JSON), is(true));
+    assertThat(ScmGitServlet.isLfsContentHeaderField("application/vnd.git-lfs+json;", CONTENT_TYPE_GIT_LFS_JSON), is(true));
+    assertThat(ScmGitServlet.isLfsContentHeaderField("application/vnd.git-lfs+json; charset=utf-8", CONTENT_TYPE_GIT_LFS_JSON), is(true));
+
+    assertThat(ScmGitServlet.isLfsContentHeaderField("application/vnd.git-lfs-json;", CONTENT_TYPE_GIT_LFS_JSON), is(false));
+    assertThat(ScmGitServlet.isLfsContentHeaderField("", CONTENT_TYPE_GIT_LFS_JSON), is(false));
+    assertThat(ScmGitServlet.isLfsContentHeaderField(null, CONTENT_TYPE_GIT_LFS_JSON), is(false));
+  }
+
+}

scm-plugins/scm-git-plugin/src/test/java/sonia/scm/web/lfs/LfsBlobStoreFactoryTest.java

@@ -0,0 +1,72 @@
+/**
+ * Copyright (c) 2010, Sebastian Sdorra
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright notice,
+ *    this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright notice,
+ *    this list of conditions and the following disclaimer in the documentation
+ *    and/or other materials provided with the distribution.
+ * 3. Neither the name of SCM-Manager; nor the names of its
+ *    contributors may be used to endorse or promote products derived from this
+ *    software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * http://bitbucket.org/sdorra/scm-manager
+ *
+ */
+
+
+package sonia.scm.web.lfs;
+
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.InjectMocks;
+import static org.mockito.Matchers.matches;
+import org.mockito.Mock;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.verifyNoMoreInteractions;
+import org.mockito.runners.MockitoJUnitRunner;
+import sonia.scm.repository.Repository;
+import sonia.scm.store.BlobStoreFactory;
+
+/**
+ * Unit tests for {@link LfsBlobStoreFactory}.
+ * 
+ * @author Sebastian Sdorra
+ */
+@RunWith(MockitoJUnitRunner.class)
+public class LfsBlobStoreFactoryTest {
+
+  @Mock
+  private BlobStoreFactory blobStoreFactory;
+  
+  @InjectMocks
+  private LfsBlobStoreFactory lfsBlobStoreFactory;
+   
+  @Test
+  public void getBlobStore() throws Exception {
+    lfsBlobStoreFactory.getLfsBlobStore(new Repository("the-id", "GIT", "the-name"));
+
+    // just make sure the right parameter is passed, as properly validating the return value is nearly impossible with 
+    // the return value (and should not be part of this test)
+    verify(blobStoreFactory).getBlobStore(matches("the-id-git-lfs"));
+
+    // make sure there have been no further usages of the factory
+    verifyNoMoreInteractions(blobStoreFactory);
+  }
+  
+}

scm-plugins/scm-git-plugin/src/test/java/sonia/scm/web/lfs/LfsStoreRemoveListenerTest.java

@@ -0,0 +1,122 @@
+/**
+ * Copyright (c) 2010, Sebastian Sdorra
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright notice,
+ *    this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright notice,
+ *    this list of conditions and the following disclaimer in the documentation
+ *    and/or other materials provided with the distribution.
+ * 3. Neither the name of SCM-Manager; nor the names of its
+ *    contributors may be used to endorse or promote products derived from this
+ *    software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * http://bitbucket.org/sdorra/scm-manager
+ *
+ */
+
+
+package sonia.scm.web.lfs;
+
+import com.google.common.collect.Lists;
+import java.util.List;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import static org.mockito.Mockito.*;
+import org.mockito.runners.MockitoJUnitRunner;
+import sonia.scm.HandlerEventType;
+import sonia.scm.repository.Repository;
+import sonia.scm.repository.RepositoryEvent;
+import sonia.scm.repository.RepositoryTestData;
+import sonia.scm.store.Blob;
+import sonia.scm.store.BlobStore;
+
+/**
+ * Unit tests for {@link LfsStoreRemoveListener}.
+ * 
+ * @author Sebastian Sdorra
+ */
+@RunWith(MockitoJUnitRunner.class)
+public class LfsStoreRemoveListenerTest {
+  
+  @Mock
+  private LfsBlobStoreFactory lfsBlobStoreFactory;
+  
+  @Mock
+  private BlobStore blobStore;
+  
+  @InjectMocks
+  private LfsStoreRemoveListener lfsStoreRemoveListener;
+  
+  @Test
+  public void testHandleRepositoryEventWithNonDeleteEvents() {
+    lfsStoreRemoveListener.handleRepositoryEvent(event(HandlerEventType.BEFORE_CREATE));
+    lfsStoreRemoveListener.handleRepositoryEvent(event(HandlerEventType.CREATE));
+    
+    lfsStoreRemoveListener.handleRepositoryEvent(event(HandlerEventType.BEFORE_MODIFY));
+    lfsStoreRemoveListener.handleRepositoryEvent(event(HandlerEventType.MODIFY));
+    
+    lfsStoreRemoveListener.handleRepositoryEvent(event(HandlerEventType.BEFORE_DELETE));
+    
+    verifyZeroInteractions(lfsBlobStoreFactory);
+  }
+  
+  @Test
+  public void testHandleRepositoryEventWithNonGitRepositories() {
+    lfsStoreRemoveListener.handleRepositoryEvent(event(HandlerEventType.DELETE, "svn"));
+    lfsStoreRemoveListener.handleRepositoryEvent(event(HandlerEventType.DELETE, "hg"));
+    lfsStoreRemoveListener.handleRepositoryEvent(event(HandlerEventType.DELETE, "dummy"));
+    
+    verifyZeroInteractions(lfsBlobStoreFactory);
+  }
+  
+  @Test
+  public void testHandleRepositoryEvent() {
+    Repository heartOfGold = RepositoryTestData.createHeartOfGold("git");
+    
+    when(lfsBlobStoreFactory.getLfsBlobStore(heartOfGold)).thenReturn(blobStore);
+    Blob blobA = mockBlob("a");
+    Blob blobB = mockBlob("b");
+    List<Blob> blobs = Lists.newArrayList(blobA, blobB);
+    when(blobStore.getAll()).thenReturn(blobs);
+    
+    
+    lfsStoreRemoveListener.handleRepositoryEvent(new RepositoryEvent(HandlerEventType.DELETE, heartOfGold));
+    verify(blobStore).getAll();
+    verify(blobStore).remove(blobA);
+    verify(blobStore).remove(blobB);
+    
+    verifyNoMoreInteractions(blobStore);
+  }
+  
+  private Blob mockBlob(String id) {
+    Blob blob = mock(Blob.class);
+    when(blob.getId()).thenReturn(id);
+    return blob;
+  }
+
+  private RepositoryEvent event(HandlerEventType eventType) {
+    return event(eventType, "git");
+  }
+  
+  private RepositoryEvent event(HandlerEventType eventType, String repositoryType) {
+    return new RepositoryEvent(eventType, RepositoryTestData.create42Puzzle(repositoryType));
+  }
+  
+}

scm-plugins/scm-git-plugin/src/test/java/sonia/scm/web/lfs/servlet/LfsServletFactoryTest.java

@@ -0,0 +1,53 @@
+package sonia.scm.web.lfs.servlet;
+
+import org.junit.Test;
+import sonia.scm.repository.Repository;
+
+import javax.servlet.http.HttpServletRequest;
+
+import static org.hamcrest.CoreMatchers.equalTo;
+import static org.hamcrest.CoreMatchers.is;
+import static org.junit.Assert.*;
+import static org.mockito.Mockito.*;
+
+/**
+ * Created by omilke on 18.05.2017.
+ */
+public class LfsServletFactoryTest {
+
+  @Test
+  public void buildBaseUri() throws Exception {
+
+    String repositoryName = "git-lfs-demo";
+
+    String result = LfsServletFactory.buildBaseUri(new Repository("", "GIT", repositoryName), RequestWithUri(repositoryName, true));
+    assertThat(result, is(equalTo("http://localhost:8081/scm/git/git-lfs-demo.git/info/lfs/objects/")));
+
+
+    //result will be with dot-gix suffix, ide
+    result = LfsServletFactory.buildBaseUri(new Repository("", "GIT", repositoryName), RequestWithUri(repositoryName, false));
+    assertThat(result, is(equalTo("http://localhost:8081/scm/git/git-lfs-demo.git/info/lfs/objects/")));
+  }
+
+  private HttpServletRequest RequestWithUri(String repositoryName, boolean withDotGitSuffix) {
+
+    HttpServletRequest mockedRequest = mock(HttpServletRequest.class);
+
+    final String suffix;
+    if (withDotGitSuffix) {
+      suffix = ".git";
+    } else {
+      suffix = "";
+    }
+
+    //build from valid live request data
+    when(mockedRequest.getRequestURL()).thenReturn(
+      new StringBuffer(String.format("http://localhost:8081/scm/git/%s%s/info/lfs/objects/batch", repositoryName, suffix)));
+    when(mockedRequest.getRequestURI()).thenReturn(String.format("/scm/git/%s%s/info/lfs/objects/batch", repositoryName, suffix));
+    when(mockedRequest.getContextPath()).thenReturn("/scm");
+
+    return mockedRequest;
+  }
+
+
+}

scm-plugins/scm-git-plugin/src/test/java/sonia/scm/web/lfs/servlet/ScmFileTransferServletTest.java

@@ -0,0 +1,42 @@
+package sonia.scm.web.lfs.servlet;
+
+import org.junit.Test;
+
+import static org.hamcrest.CoreMatchers.equalTo;
+import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.CoreMatchers.nullValue;
+import static org.junit.Assert.*;
+
+/**
+ * Created by omilke on 16.05.2017.
+ */
+public class ScmFileTransferServletTest {
+
+  @Test
+  public void hasObjectId() throws Exception {
+
+    String SAMPLE_OBJECT_ID = "8fcebeb5698230685f92028e560f8f1683ebc15ec82a620ffad5c12a3c19bdec";
+
+    String path = "/git-lfs-demo.git/info/lfs/objects/" + SAMPLE_OBJECT_ID;
+    assertThat(ScmFileTransferServlet.objectIdFromPath(path), is(equalTo(SAMPLE_OBJECT_ID)));
+
+    path = "/" + SAMPLE_OBJECT_ID;
+    assertThat(ScmFileTransferServlet.objectIdFromPath(path), is(equalTo(SAMPLE_OBJECT_ID)));
+
+    path = SAMPLE_OBJECT_ID;
+    assertThat(ScmFileTransferServlet.objectIdFromPath(path), is(equalTo(SAMPLE_OBJECT_ID)));
+
+    String nonObjectId = "this-ist-last-to-found";
+    path = "/git-lfs-demo.git/info/lfs/objects/" + nonObjectId;
+    assertThat(ScmFileTransferServlet.objectIdFromPath(path), is(nullValue()));
+
+    nonObjectId = SAMPLE_OBJECT_ID.substring(1);
+    path = "/git-lfs-demo.git/info/lfs/objects/" + nonObjectId;
+    assertThat(ScmFileTransferServlet.objectIdFromPath(path), is(nullValue()));
+
+    nonObjectId = SAMPLE_OBJECT_ID + "X";
+    path = "/git-lfs-demo.git/info/lfs/objects/" + nonObjectId;
+    assertThat(ScmFileTransferServlet.objectIdFromPath(path), is(nullValue()));
+
+  }
+}