Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-17 10:41:06 +01:00
Code Issues Packages Projects Releases Activity

Do not use Optional for modification date

Browse Source 
First, Optionals should not be used for fields,
second this does not provide any benefits
This commit is contained in:
René Pfeuffer
2018-07-03 09:38:56 +02:00
parent 54776548ea
commit ad60bae74e
5 changed files with 7 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
scm-webapp/src/test/java/sonia/scm/api/v2/resources/UserDtoToUserMapperTest.java
View File

@@ -8,7 +8,6 @@ import org.mockito.Mock;
import sonia.scm.user.User;
import java.time.Instant;
import java.util.Optional;
import static org.junit.Assert.assertEquals;
import static org.mockito.Mockito.when;
@@ -47,7 +46,7 @@ public class UserDtoToUserMapperTest {
UserDto dto = new UserDto();
dto.setName("abc");
dto.setCreationDate(Instant.now());
dto.setLastModified(Optional.empty());
dto.setLastModified(null);
return dto;
}
}

2
scm-webapp/src/test/java/sonia/scm/api/v2/resources/UserToUserDtoMapperTest.java
View File

@@ -122,6 +122,6 @@ public class UserToUserDtoMapperTest {
UserDto userDto = mapper.map(user);
assertEquals(expectedCreationDate, userDto.getCreationDate());
assertEquals(expectedModificationDate, userDto.getLastModified().get());
assertEquals(expectedModificationDate, userDto.getLastModified());
}
}