Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-12-22 00:09:47 +01:00
Code Issues Packages Projects Releases Activity

Disable repository types (#1908)

Browse Source 
Disable repository types via global config for Git, Mercurial and Subversion. It is only possible to disable a type, if no repositories of this type exist. Also prevent repository creation if no type is allowed at all to catch nasty errors.

Co-authored-by: Konstantin Schaper <konstantin.schaper@cloudogu.com>
This commit is contained in:
Eduard Heimbuch
2022-01-06 10:05:01 +01:00
committed by GitHub
parent 82ac06f896
commit aa1558dbac
24 changed files with 252 additions and 185 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
scm-plugins/scm-svn-plugin/src/test/java/sonia/scm/api/v2/resources/SvnConfigResourceTest.java
View File

@@ -38,6 +38,7 @@ import org.mockito.Answers;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.junit.MockitoJUnitRunner;
import sonia.scm.repository.RepositoryManager;
import sonia.scm.repository.SvnConfig;
import sonia.scm.repository.SvnRepositoryHandler;
import sonia.scm.web.RestDispatcher;
@@ -68,6 +69,9 @@ public class SvnConfigResourceTest {
private final URI baseUri = URI.create("/");
@Mock
private RepositoryManager repositoryManager;
@InjectMocks
private SvnConfigDtoToSvnConfigMapperImpl dtoToConfigMapper;

21
scm-plugins/scm-svn-plugin/src/test/java/sonia/scm/api/v2/resources/SvnConfigToSvnConfigDtoMapperTest.java
View File

@@ -37,9 +37,12 @@ import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.junit.MockitoJUnitRunner;
import sonia.scm.repository.Compatibility;
import sonia.scm.repository.RepositoryManager;
import sonia.scm.repository.RepositoryTestData;
import sonia.scm.repository.SvnConfig;
import java.net.URI;
import java.util.Collections;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
@@ -50,11 +53,14 @@ import static org.mockito.Mockito.when;
@RunWith(MockitoJUnitRunner.class)
public class SvnConfigToSvnConfigDtoMapperTest {
private URI baseUri = URI.create("http://example.com/base/");
private final URI baseUri = URI.create("http://example.com/base/");
@Mock(answer = Answers.RETURNS_DEEP_STUBS)
private ScmPathInfoStore scmPathInfoStore;
@Mock
private RepositoryManager manager;
@InjectMocks
private SvnConfigToSvnConfigDtoMapperImpl mapper;
@@ -80,10 +86,12 @@ public class SvnConfigToSvnConfigDtoMapperTest {
public void shouldMapFields() {
SvnConfig config = createConfiguration();
when(manager.getAll()).thenReturn(Collections.singleton(RepositoryTestData.create42Puzzle("svn")));
when(subject.isPermitted("configuration:write:svn")).thenReturn(true);
SvnConfigDto dto = mapper.map(config);
assertTrue(dto.isDisabled());
assertFalse(dto.isAllowDisable());
assertEquals(Compatibility.PRE15, dto.getCompatibility());
assertTrue(dto.isEnabledGZip());
@@ -92,6 +100,17 @@ public class SvnConfigToSvnConfigDtoMapperTest {
assertEquals(expectedBaseUri.toString(), dto.getLinks().getLinkBy("update").get().getHref());
}
@Test
public void shouldAllowDisableIfNoSubversionRepositoriesExist() {
SvnConfig config = createConfiguration();
when(manager.getAll()).thenReturn(Collections.singleton(RepositoryTestData.create42Puzzle("git")));
when(subject.isPermitted("configuration:write:svn")).thenReturn(true);
SvnConfigDto dto = mapper.map(config);
assertTrue(dto.isAllowDisable());
}
@Test
public void shouldMapFieldsWithoutUpdate() {
SvnConfig config = createConfiguration();