Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-12 00:15:44 +01:00
Code Issues Packages Projects Releases Activity

Replace custom exception messages with generic ones

Browse Source
This commit is contained in:
René Pfeuffer
2018-09-21 11:38:32 +02:00
parent 89377c665c
commit a89353adff
3 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
scm-core/src/main/java/sonia/scm/NotFoundException.java
View File

@@ -7,9 +7,4 @@ public class NotFoundException extends Exception {
public NotFoundException() { public NotFoundException() {
} }
public NotFoundException(String message) {
super(message);
}
} }

2
scm-webapp/src/main/java/sonia/scm/api/v2/resources/BranchRootResource.java
View File

@@ -106,7 +106,7 @@ public class BranchRootResource {
.stream() .stream()
.anyMatch(branch -> branchName.equals(branch.getName())); .anyMatch(branch -> branchName.equals(branch.getName()));
if (!branchExists){ if (!branchExists){
throw new NotFoundException(MessageFormat.format("The branch {0} is not found", branchName)); throw new NotFoundException("branch", branchName);
} }
Repository repository = repositoryService.getRepository(); Repository repository = repositoryService.getRepository();
RepositoryPermissions.read(repository).check(); RepositoryPermissions.read(repository).check();

2
scm-webapp/src/main/java/sonia/scm/api/v2/resources/PermissionRootResource.java
View File

@@ -162,7 +162,7 @@ public class PermissionRootResource {
RepositoryPermissions.permissionWrite(repository).check(); RepositoryPermissions.permissionWrite(repository).check();
String extractedPermissionName = getPermissionName(permissionName); String extractedPermissionName = getPermissionName(permissionName);
if (!isPermissionExist(new PermissionDto(extractedPermissionName, isGroupPermission(permissionName)), repository)) { if (!isPermissionExist(new PermissionDto(extractedPermissionName, isGroupPermission(permissionName)), repository)) {
throw new NotFoundException("the permission " + extractedPermissionName + " does not exist"); throw new NotFoundException("permission", extractedPermissionName);
} }
permission.setGroupPermission(isGroupPermission(permissionName)); permission.setGroupPermission(isGroupPermission(permissionName));
if (!extractedPermissionName.equals(permission.getName())) { if (!extractedPermissionName.equals(permission.getName())) {