Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-12 08:25:44 +01:00
Code Issues Packages Projects Releases Activity

remove redundant nullcheck

Browse Source
This commit is contained in:
Sebastian Sdorra
2012-10-30 08:15:57 +01:00
parent 61361f8b87
commit 9e7e8a3f40
1 changed files with 15 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
scm-core/src/main/java/sonia/scm/repository/AbstactImportHandler.java
View File

@@ -30,6 +30,7 @@
*/ */
package sonia.scm.repository; package sonia.scm.repository;
//~--- non-JDK imports -------------------------------------------------------- //~--- non-JDK imports --------------------------------------------------------
@@ -116,11 +117,9 @@ public abstract class AbstactImportHandler implements ImportHandler
if (repository == null) if (repository == null)
{ {
if (importRepository(manager, repositoryName)) importRepository(manager, repositoryName);
{
imported.add(repositoryName); imported.add(repositoryName);
} }
}
else if (logger.isDebugEnabled()) else if (logger.isDebugEnabled())
{ {
logger.debug("repository {} is allready managed", repositoryName); logger.debug("repository {} is allready managed", repositoryName);
@@ -167,16 +166,13 @@ public abstract class AbstactImportHandler implements ImportHandler
* @throws IOException * @throws IOException
* @throws RepositoryException * @throws RepositoryException
*/ */
private boolean importRepository(RepositoryManager manager, private void importRepository(RepositoryManager manager,
String repositoryName) String repositoryName)
throws IOException, RepositoryException throws IOException, RepositoryException
{ {
boolean result = false;
Repository repository = Repository repository =
createRepository(getRepositoryDirectory(repositoryName), repositoryName); createRepository(getRepositoryDirectory(repositoryName), repositoryName);
if (repository != null)
{
if (logger.isInfoEnabled()) if (logger.isInfoEnabled())
{ {
logger.info("import repository {} of type {}", repositoryName, logger.info("import repository {} of type {}", repositoryName,
@@ -184,14 +180,6 @@ public abstract class AbstactImportHandler implements ImportHandler
} }
manager.importRepository(repository); manager.importRepository(repository);
result = true;
}
else if (logger.isWarnEnabled())
{
logger.warn("could not create repository object for {}", repositoryName);
}
return result;
} }
//~--- get methods ---------------------------------------------------------- //~--- get methods ----------------------------------------------------------