implement simplified PluginManager API

2025-11-14 09:25:43 +01:00 · 2019-08-20 12:29:59 +02:00
parent 3f1521bcca
commit 9d66f14627
9 changed files with 443 additions and 32 deletions
--- a/scm-webapp/src/test/java/sonia/scm/plugin/DefaultPluginManagerTest.java
+++ b/scm-webapp/src/test/java/sonia/scm/plugin/DefaultPluginManagerTest.java
@@ -0,0 +1,149 @@
+package sonia.scm.plugin;
+
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.ImmutableSet;
+import org.checkerframework.checker.nullness.Opt;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.Answers;
+import org.mockito.InjectMocks;
+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+import java.util.Arrays;
+import java.util.List;
+import java.util.Optional;
+import java.util.Set;
+import java.util.stream.Collectors;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.jupiter.api.Assertions.*;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+@ExtendWith(MockitoExtension.class)
+class DefaultPluginManagerTest {
+
+  @Mock
+  private PluginLoader loader;
+
+  @Mock
+  private PluginCenter center;
+
+  @InjectMocks
+  private DefaultPluginManager manager;
+
+  @Test
+  void shouldReturnInstalledPlugins() {
+    InstalledPlugin review = createInstalled("scm-review-plugin");
+    InstalledPlugin git = createInstalled("scm-git-plugin");
+
+    when(loader.getInstalledPlugins()).thenReturn(ImmutableList.of(review, git));
+
+    List<InstalledPlugin> installed = manager.getInstalled();
+    assertThat(installed).containsOnly(review, git);
+  }
+
+  @Test
+  void shouldReturnReviewPlugin() {
+    InstalledPlugin review = createInstalled("scm-review-plugin");
+    InstalledPlugin git = createInstalled("scm-git-plugin");
+
+    when(loader.getInstalledPlugins()).thenReturn(ImmutableList.of(review, git));
+
+    Optional<InstalledPlugin> plugin = manager.getInstalled("scm-review-plugin");
+    assertThat(plugin).contains(review);
+  }
+
+  @Test
+  void shouldReturnEmptyForNonInstalledPlugin() {
+    when(loader.getInstalledPlugins()).thenReturn(ImmutableList.of());
+
+    Optional<InstalledPlugin> plugin = manager.getInstalled("scm-review-plugin");
+    assertThat(plugin).isEmpty();
+  }
+
+  @Test
+  void shouldReturnAvailablePlugins() {
+    AvailablePlugin review = createAvailable("scm-review-plugin");
+    AvailablePlugin git = createAvailable("scm-git-plugin");
+
+    when(center.getAvailable()).thenReturn(ImmutableSet.of(review, git));
+
+    List<AvailablePlugin> available = manager.getAvailable();
+    assertThat(available).containsOnly(review, git);
+  }
+
+  @Test
+  void shouldFilterOutAllInstalled() {
+    InstalledPlugin installedGit = createInstalled("scm-git-plugin");
+    when(loader.getInstalledPlugins()).thenReturn(ImmutableList.of(installedGit));
+
+    AvailablePlugin review = createAvailable("scm-review-plugin");
+    AvailablePlugin git = createAvailable("scm-git-plugin");
+    when(center.getAvailable()).thenReturn(ImmutableSet.of(review, git));
+
+    List<AvailablePlugin> available = manager.getAvailable();
+    assertThat(available).containsOnly(review);
+  }
+
+  @Test
+  void shouldReturnAvailable() {
+    AvailablePlugin review = createAvailable("scm-review-plugin");
+    AvailablePlugin git = createAvailable("scm-git-plugin");
+    when(center.getAvailable()).thenReturn(ImmutableSet.of(review, git));
+
+    Optional<AvailablePlugin> available = manager.getAvailable("scm-git-plugin");
+    assertThat(available).contains(git);
+  }
+
+  @Test
+  void shouldReturnEmptyForNonExistingAvailable() {
+    AvailablePlugin review = createAvailable("scm-review-plugin");
+    when(center.getAvailable()).thenReturn(ImmutableSet.of(review));
+
+    Optional<AvailablePlugin> available = manager.getAvailable("scm-git-plugin");
+    assertThat(available).isEmpty();
+  }
+
+  @Test
+  void shouldReturnEmptyForInstalledPlugin() {
+    InstalledPlugin installedGit = createInstalled("scm-git-plugin");
+    when(loader.getInstalledPlugins()).thenReturn(ImmutableList.of(installedGit));
+
+    AvailablePlugin git = createAvailable("scm-git-plugin");
+    when(center.getAvailable()).thenReturn(ImmutableSet.of(git));
+
+    Optional<AvailablePlugin> available = manager.getAvailable("scm-git-plugin");
+    assertThat(available).isEmpty();
+  }
+
+  private AvailablePlugin createAvailable(String name) {
+    PluginInformation information = new PluginInformation();
+    information.setName(name);
+    return createAvailable(information);
+  }
+
+  private InstalledPlugin createInstalled(String name) {
+    PluginInformation information = new PluginInformation();
+    information.setName(name);
+    return createInstalled(information);
+  }
+
+  private InstalledPlugin createInstalled(PluginInformation information) {
+    InstalledPlugin plugin = mock(InstalledPlugin.class, Answers.RETURNS_DEEP_STUBS);
+    returnInformation(plugin, information);
+    return plugin;
+  }
+
+  private AvailablePlugin createAvailable(PluginInformation information) {
+    AvailablePlugin plugin = mock(AvailablePlugin.class, Answers.RETURNS_DEEP_STUBS);
+    returnInformation(plugin, information);
+    return plugin;
+  }
+
+  private void returnInformation(Plugin mockedPlugin, PluginInformation information) {
+    when(mockedPlugin.getDescriptor().getInformation()).thenReturn(information);
+  }
+
+}