review

scm-webapp/src/main/java/sonia/scm/api/v2/resources/ModificationsDto.java

@@ -36,10 +36,4 @@ public class ModificationsDto extends HalRepresentation {
     return super.add(links);
   }
 
-  @SuppressWarnings("squid:S1185") // We want to have this method available in this package
-  protected HalRepresentation withEmbedded(String rel, List<? extends HalRepresentation> halRepresentations) {
-    return super.withEmbedded(rel, halRepresentations);
-  }
-
-
 }

scm-webapp/src/main/java/sonia/scm/api/v2/resources/ModificationsRootResource.java

@@ -34,20 +34,12 @@ public class ModificationsRootResource {
   /**
    * Get the file modifications related to a revision.
    * file modifications are for example: Modified, Added or Removed.
-   *
-   * @param namespace
-   * @param name
-   * @param revision
-   * @return
-   * @throws IOException
-   * @throws RevisionNotFoundException
-   * @throws RepositoryNotFoundException
    */
   @GET
   @StatusCodes({
     @ResponseCode(code = 200, condition = "success"),
     @ResponseCode(code = 401, condition = "not authenticated / invalid credentials"),
-    @ResponseCode(code = 403, condition = "not authorized, the current user has no privileges to read the changeset"),
+    @ResponseCode(code = 403, condition = "not authorized, the current user has no privileges to read the modifications"),
     @ResponseCode(code = 404, condition = "not found, no changeset with the specified id is available in the repository"),
     @ResponseCode(code = 500, condition = "internal server error")
   })

scm-webapp/src/main/java/sonia/scm/api/v2/resources/ModificationsToDtoMapper.java

@@ -14,7 +14,7 @@ import javax.inject.Inject;
 import static de.otto.edison.hal.Links.linkingTo;
 
 @Mapper
-public abstract class ModificationsToDtoMapper extends BaseMapper<Modifications, ModificationsDto> {
+public abstract class ModificationsToDtoMapper {
 
   @Inject
   private ResourceLinks resourceLinks;