From b69c06960e598177148a936045bcdbe52df8207a Mon Sep 17 00:00:00 2001 From: Florian Scholdei Date: Fri, 21 Dec 2018 13:41:34 +0100 Subject: [PATCH 1/7] added icons to navigation --- .../ui-components/src/navigation/NavAction.js | 11 +++++++++-- .../packages/ui-components/src/navigation/NavLink.js | 11 ++++++++++- .../groups/components/navLinks/DeleteGroupNavLink.js | 2 +- .../groups/components/navLinks/EditGroupNavLink.js | 2 +- scm-ui/src/groups/containers/SingleGroup.js | 3 ++- scm-ui/src/repos/components/DeleteNavAction.js | 2 +- .../users/components/navLinks/DeleteUserNavLink.js | 2 +- .../src/users/components/navLinks/EditUserNavLink.js | 2 +- scm-ui/src/users/containers/SingleUser.js | 1 + 9 files changed, 27 insertions(+), 9 deletions(-) diff --git a/scm-ui-components/packages/ui-components/src/navigation/NavAction.js b/scm-ui-components/packages/ui-components/src/navigation/NavAction.js index 5eacbb7407..3ae30d4b68 100644 --- a/scm-ui-components/packages/ui-components/src/navigation/NavAction.js +++ b/scm-ui-components/packages/ui-components/src/navigation/NavAction.js @@ -2,16 +2,23 @@ import React from "react"; type Props = { + icon?: string, label: string, action: () => void }; class NavAction extends React.Component { render() { - const { label, action } = this.props; + const { label, icon, action } = this.props; + + let showIcon = null; + if (icon) { + showIcon = (<>{" "}); + } + return (
  • - {label} + {showIcon}{label}
  • ); } diff --git a/scm-ui-components/packages/ui-components/src/navigation/NavLink.js b/scm-ui-components/packages/ui-components/src/navigation/NavLink.js index 9a7c72adb1..53b124ef31 100644 --- a/scm-ui-components/packages/ui-components/src/navigation/NavLink.js +++ b/scm-ui-components/packages/ui-components/src/navigation/NavLink.js @@ -6,6 +6,7 @@ import {Link, Route} from "react-router-dom"; type Props = { to: string, + icon?: string, label: string, activeOnlyWhenExact?: boolean, activeWhenMatch?: (route: any) => boolean @@ -23,10 +24,17 @@ class NavLink extends React.Component { } renderLink = (route: any) => { - const { to, label } = this.props; + const { to, icon, label } = this.props; + + let showIcon = null; + if (icon) { + showIcon = (<>{" "}); + } + return (
  • + {showIcon} {label}
  • @@ -35,6 +43,7 @@ class NavLink extends React.Component { render() { const { to, activeOnlyWhenExact } = this.props; + return ( ); diff --git a/scm-ui/src/groups/components/navLinks/DeleteGroupNavLink.js b/scm-ui/src/groups/components/navLinks/DeleteGroupNavLink.js index 45bbdd3026..8021e468b3 100644 --- a/scm-ui/src/groups/components/navLinks/DeleteGroupNavLink.js +++ b/scm-ui/src/groups/components/navLinks/DeleteGroupNavLink.js @@ -49,7 +49,7 @@ export class DeleteGroupNavLink extends React.Component { if (!this.isDeletable()) { return null; } - return ; + return ; } } diff --git a/scm-ui/src/groups/components/navLinks/EditGroupNavLink.js b/scm-ui/src/groups/components/navLinks/EditGroupNavLink.js index a0e36bc8d7..8cb46f691d 100644 --- a/scm-ui/src/groups/components/navLinks/EditGroupNavLink.js +++ b/scm-ui/src/groups/components/navLinks/EditGroupNavLink.js @@ -18,7 +18,7 @@ class EditGroupNavLink extends React.Component { if (!this.isEditable()) { return null; } - return ; + return ; } isEditable = () => { diff --git a/scm-ui/src/groups/containers/SingleGroup.js b/scm-ui/src/groups/containers/SingleGroup.js index 1dd4aa569f..6a626f325b 100644 --- a/scm-ui/src/groups/containers/SingleGroup.js +++ b/scm-ui/src/groups/containers/SingleGroup.js @@ -109,6 +109,7 @@ class SingleGroup extends React.Component {
    @@ -117,7 +118,7 @@ class SingleGroup extends React.Component { deleteGroup={this.deleteGroup} /> - +
    diff --git a/scm-ui/src/repos/components/DeleteNavAction.js b/scm-ui/src/repos/components/DeleteNavAction.js index c2369a5bfb..2d00b99bd4 100644 --- a/scm-ui/src/repos/components/DeleteNavAction.js +++ b/scm-ui/src/repos/components/DeleteNavAction.js @@ -51,7 +51,7 @@ class DeleteNavAction extends React.Component { if (!this.isDeletable()) { return null; } - return ; + return ; } } diff --git a/scm-ui/src/users/components/navLinks/DeleteUserNavLink.js b/scm-ui/src/users/components/navLinks/DeleteUserNavLink.js index 47fdae0f92..80c355e999 100644 --- a/scm-ui/src/users/components/navLinks/DeleteUserNavLink.js +++ b/scm-ui/src/users/components/navLinks/DeleteUserNavLink.js @@ -49,7 +49,7 @@ class DeleteUserNavLink extends React.Component { if (!this.isDeletable()) { return null; } - return ; + return ; } } diff --git a/scm-ui/src/users/components/navLinks/EditUserNavLink.js b/scm-ui/src/users/components/navLinks/EditUserNavLink.js index 9999428212..3632f8da51 100644 --- a/scm-ui/src/users/components/navLinks/EditUserNavLink.js +++ b/scm-ui/src/users/components/navLinks/EditUserNavLink.js @@ -17,7 +17,7 @@ class EditUserNavLink extends React.Component { if (!this.isEditable()) { return null; } - return ; + return ; } isEditable = () => { diff --git a/scm-ui/src/users/containers/SingleUser.js b/scm-ui/src/users/containers/SingleUser.js index 5f20598962..b6660f2aef 100644 --- a/scm-ui/src/users/containers/SingleUser.js +++ b/scm-ui/src/users/containers/SingleUser.js @@ -111,6 +111,7 @@ class SingleUser extends React.Component {
    From a0f9710860a3463ac047abfd0b4e164f08a24ed6 Mon Sep 17 00:00:00 2001 From: Florian Scholdei Date: Fri, 21 Dec 2018 13:53:59 +0100 Subject: [PATCH 2/7] added more navicons --- scm-ui/src/repos/components/EditNavLink.js | 2 +- scm-ui/src/repos/components/PermissionsNavLink.js | 2 +- scm-ui/src/repos/containers/RepositoryRoot.js | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/scm-ui/src/repos/components/EditNavLink.js b/scm-ui/src/repos/components/EditNavLink.js index 1a49fdee81..a42625a154 100644 --- a/scm-ui/src/repos/components/EditNavLink.js +++ b/scm-ui/src/repos/components/EditNavLink.js @@ -15,7 +15,7 @@ class EditNavLink extends React.Component { return null; } const { editUrl, t } = this.props; - return ; + return ; } } diff --git a/scm-ui/src/repos/components/PermissionsNavLink.js b/scm-ui/src/repos/components/PermissionsNavLink.js index cb6d0e0723..70d5cec2e2 100644 --- a/scm-ui/src/repos/components/PermissionsNavLink.js +++ b/scm-ui/src/repos/components/PermissionsNavLink.js @@ -20,7 +20,7 @@ class PermissionsNavLink extends React.Component { } const { permissionUrl, t } = this.props; return ( - + ); } } diff --git a/scm-ui/src/repos/containers/RepositoryRoot.js b/scm-ui/src/repos/containers/RepositoryRoot.js index a3f69fe70b..d24224fe17 100644 --- a/scm-ui/src/repos/containers/RepositoryRoot.js +++ b/scm-ui/src/repos/containers/RepositoryRoot.js @@ -182,11 +182,12 @@ class RepositoryRoot extends React.Component {
    - + { repository={repository} linkName="sources" to={`${url}/sources`} + icon="fas fa-code" label={t("repository-root.sources")} activeOnlyWhenExact={false} /> From f3ee18767eb48a95a6df1f453862b6cdd3b7c517 Mon Sep 17 00:00:00 2001 From: Florian Scholdei Date: Fri, 21 Dec 2018 13:55:36 +0100 Subject: [PATCH 3/7] moved editNavLink in action section --- scm-ui/src/repos/containers/RepositoryRoot.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scm-ui/src/repos/containers/RepositoryRoot.js b/scm-ui/src/repos/containers/RepositoryRoot.js index d24224fe17..31187702a8 100644 --- a/scm-ui/src/repos/containers/RepositoryRoot.js +++ b/scm-ui/src/repos/containers/RepositoryRoot.js @@ -209,10 +209,10 @@ class RepositoryRoot extends React.Component { permissionUrl={`${url}/permissions`} repository={repository} /> -
    +
    From 8eb5e7786abad8c1b36c153f08cb2b9416c4806d Mon Sep 17 00:00:00 2001 From: Florian Scholdei Date: Fri, 21 Dec 2018 14:08:19 +0100 Subject: [PATCH 4/7] added navicons --- scm-ui/src/containers/Profile.js | 2 +- scm-ui/src/groups/components/navLinks/EditGroupNavLink.js | 2 +- scm-ui/src/groups/containers/SingleGroup.js | 4 ++-- scm-ui/src/repos/components/DeleteNavAction.js | 2 +- scm-ui/src/repos/components/PermissionsNavLink.js | 2 +- scm-ui/src/repos/containers/RepositoryRoot.js | 4 ++-- scm-ui/src/users/components/navLinks/EditUserNavLink.js | 2 +- scm-ui/src/users/components/navLinks/SetPasswordNavLink.js | 2 +- scm-ui/src/users/containers/SingleUser.js | 4 ++-- 9 files changed, 12 insertions(+), 12 deletions(-) diff --git a/scm-ui/src/containers/Profile.js b/scm-ui/src/containers/Profile.js index b40f5f3ee0..3464e125dd 100644 --- a/scm-ui/src/containers/Profile.js +++ b/scm-ui/src/containers/Profile.js @@ -70,7 +70,7 @@ class Profile extends React.Component {
    - +
    { if (!this.isEditable()) { return null; } - return ; + return ; } isEditable = () => { diff --git a/scm-ui/src/groups/containers/SingleGroup.js b/scm-ui/src/groups/containers/SingleGroup.js index 6a626f325b..0e56354288 100644 --- a/scm-ui/src/groups/containers/SingleGroup.js +++ b/scm-ui/src/groups/containers/SingleGroup.js @@ -108,8 +108,8 @@ class SingleGroup extends React.Component {
    @@ -118,7 +118,7 @@ class SingleGroup extends React.Component { deleteGroup={this.deleteGroup} /> - +
    diff --git a/scm-ui/src/repos/components/DeleteNavAction.js b/scm-ui/src/repos/components/DeleteNavAction.js index 2d00b99bd4..fe35a9caf1 100644 --- a/scm-ui/src/repos/components/DeleteNavAction.js +++ b/scm-ui/src/repos/components/DeleteNavAction.js @@ -51,7 +51,7 @@ class DeleteNavAction extends React.Component { if (!this.isDeletable()) { return null; } - return ; + return ; } } diff --git a/scm-ui/src/repos/components/PermissionsNavLink.js b/scm-ui/src/repos/components/PermissionsNavLink.js index 70d5cec2e2..3a6f97588b 100644 --- a/scm-ui/src/repos/components/PermissionsNavLink.js +++ b/scm-ui/src/repos/components/PermissionsNavLink.js @@ -20,7 +20,7 @@ class PermissionsNavLink extends React.Component { } const { permissionUrl, t } = this.props; return ( - + ); } } diff --git a/scm-ui/src/repos/containers/RepositoryRoot.js b/scm-ui/src/repos/containers/RepositoryRoot.js index 31187702a8..2ffa18e6b7 100644 --- a/scm-ui/src/repos/containers/RepositoryRoot.js +++ b/scm-ui/src/repos/containers/RepositoryRoot.js @@ -182,7 +182,7 @@ class RepositoryRoot extends React.Component {
    - + {
    - +
    diff --git a/scm-ui/src/users/components/navLinks/EditUserNavLink.js b/scm-ui/src/users/components/navLinks/EditUserNavLink.js index 3632f8da51..8be8dbc621 100644 --- a/scm-ui/src/users/components/navLinks/EditUserNavLink.js +++ b/scm-ui/src/users/components/navLinks/EditUserNavLink.js @@ -17,7 +17,7 @@ class EditUserNavLink extends React.Component { if (!this.isEditable()) { return null; } - return ; + return ; } isEditable = () => { diff --git a/scm-ui/src/users/components/navLinks/SetPasswordNavLink.js b/scm-ui/src/users/components/navLinks/SetPasswordNavLink.js index 43b7a4b5a4..46e931e788 100644 --- a/scm-ui/src/users/components/navLinks/SetPasswordNavLink.js +++ b/scm-ui/src/users/components/navLinks/SetPasswordNavLink.js @@ -17,7 +17,7 @@ class ChangePasswordNavLink extends React.Component { if (!this.hasPermissionToSetPassword()) { return null; } - return ; + return ; } hasPermissionToSetPassword = () => { diff --git a/scm-ui/src/users/containers/SingleUser.js b/scm-ui/src/users/containers/SingleUser.js index b6660f2aef..ce6e3eba50 100644 --- a/scm-ui/src/users/containers/SingleUser.js +++ b/scm-ui/src/users/containers/SingleUser.js @@ -111,8 +111,8 @@ class SingleUser extends React.Component {
    @@ -123,7 +123,7 @@ class SingleUser extends React.Component {
    - +
    From 28ac14f5f9c0b80419bc1689a16c7ac8f798fcda Mon Sep 17 00:00:00 2001 From: Florian Scholdei Date: Wed, 2 Jan 2019 15:03:45 +0100 Subject: [PATCH 5/7] corrected unit tests for icon cases --- scm-ui/src/repos/components/EditNavLink.test.js | 2 +- scm-ui/src/repos/components/PermissionsNavLink.test.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scm-ui/src/repos/components/EditNavLink.test.js b/scm-ui/src/repos/components/EditNavLink.test.js index 935b7cf928..fdb13ade8d 100644 --- a/scm-ui/src/repos/components/EditNavLink.test.js +++ b/scm-ui/src/repos/components/EditNavLink.test.js @@ -33,6 +33,6 @@ describe("EditNavLink", () => { , options.get() ); - expect(navLink.text()).toBe("edit-nav-link.label"); + expect(navLink.text()).toBe(" edit-nav-link.label"); }); }); diff --git a/scm-ui/src/repos/components/PermissionsNavLink.test.js b/scm-ui/src/repos/components/PermissionsNavLink.test.js index 450c7f49e6..901175caa0 100644 --- a/scm-ui/src/repos/components/PermissionsNavLink.test.js +++ b/scm-ui/src/repos/components/PermissionsNavLink.test.js @@ -33,6 +33,6 @@ describe("PermissionsNavLink", () => { , options.get() ); - expect(navLink.text()).toBe("repository-root.permissions"); + expect(navLink.text()).toBe(" repository-root.permissions"); }); }); From 329241f29d428036de885d25f01df42534f2c926 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maren=20S=C3=BCwer?= Date: Fri, 11 Jan 2019 12:08:19 +0100 Subject: [PATCH 6/7] remove brackets --- scm-ui/src/groups/containers/SingleGroup.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/scm-ui/src/groups/containers/SingleGroup.js b/scm-ui/src/groups/containers/SingleGroup.js index 0e56354288..ffc1f5feda 100644 --- a/scm-ui/src/groups/containers/SingleGroup.js +++ b/scm-ui/src/groups/containers/SingleGroup.js @@ -108,7 +108,7 @@ class SingleGroup extends React.Component {
    @@ -118,7 +118,11 @@ class SingleGroup extends React.Component { deleteGroup={this.deleteGroup} /> - +
    From f68a59e5d1481596762026d1738716ae3547136a Mon Sep 17 00:00:00 2001 From: Florian Scholdei Date: Wed, 23 Jan 2019 15:44:29 +0000 Subject: [PATCH 7/7] Close branch feature/ux_icons