Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-13 00:45:44 +01:00
Code Issues Packages Projects Releases Activity

PluginInstaller returns now PendingPluginInstallation, to abort the installation before restart

Browse Source
This commit is contained in:
Sebastian Sdorra
2019-08-20 16:38:29 +02:00
parent e24673be0a
commit 8db2bbb28d
5 changed files with 100 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
scm-webapp/src/main/java/sonia/scm/plugin/PendingPluginInstallation.java Normal file
View File

@@ -0,0 +1,31 @@
package sonia.scm.plugin;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import java.io.File;
class PendingPluginInstallation {
private static final Logger LOG = LoggerFactory.getLogger(PendingPluginInstallation.class);
private final AvailablePlugin plugin;
private final File file;
PendingPluginInstallation(AvailablePlugin plugin, File file) {
this.plugin = plugin;
this.file = file;
}
public AvailablePlugin getPlugin() {
return plugin;
}
void cancel() {
String name = plugin.getDescriptor().getInformation().getName();
LOG.info("cancel installation of plugin {}", name);
if (!file.delete()) {
throw new PluginFailedToCancelInstallationException("failed to cancel installation of plugin " + name);
}
}
}

7
scm-webapp/src/main/java/sonia/scm/plugin/PluginFailedToCancelInstallationException.java Normal file
View File

@@ -0,0 +1,7 @@
package sonia.scm.plugin;
public class PluginFailedToCancelInstallationException extends RuntimeException {
public PluginFailedToCancelInstallationException(String message) {
super(message);
}
}

8
scm-webapp/src/main/java/sonia/scm/plugin/PluginInstaller.java
View File

@@ -1,7 +1,5 @@
package sonia.scm.plugin;
import com.google.common.base.Throwables;
import com.google.common.hash.HashFunction;
import com.google.common.hash.Hashing;
import com.google.common.io.ByteStreams;
import com.google.common.io.Files;
@@ -28,12 +26,16 @@ class PluginInstaller {
this.client = client;
}
public void install(AvailablePlugin plugin) {
public PendingPluginInstallation install(AvailablePlugin plugin) {
File file = createFile(plugin);
try (InputStream input = download(plugin); OutputStream output = new FileOutputStream(file)) {
ByteStreams.copy(input, output);
verifyChecksum(plugin, file);
// TODO clean up in case of error
return new PendingPluginInstallation(plugin, file);
} catch (IOException ex) {
throw new PluginDownloadException("failed to install plugin", ex);
}