added unit test for XmlUserHandler

pom.xml

@@ -78,6 +78,13 @@
       <scope>test</scope>
     </dependency>
 
+    <dependency>
+      <groupId>org.mockito</groupId>
+      <artifactId>mockito-all</artifactId>
+      <version>1.8.5</version>
+      <scope>test</scope>
+    </dependency>
+
   </dependencies>
 
   <build>

scm-core/pom.xml

@@ -29,6 +29,13 @@
       <version>${guice.version}</version>
     </dependency>
 
+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-simple</artifactId>
+      <version>${slf4j.version}</version>
+      <scope>test</scope>
+    </dependency>
+
   </dependencies>
 
 </project>

scm-core/src/main/java/sonia/scm/user/User.java

@@ -87,6 +87,99 @@ public class User implements TypedObject, Principal, Serializable
     this.mail = mail;
   }
 
+  //~--- methods --------------------------------------------------------------
+
+  /**
+   * Method description
+   *
+   *
+   * @param obj
+   *
+   * @return
+   */
+  @Override
+  public boolean equals(Object obj)
+  {
+    if (obj == null)
+    {
+      return false;
+    }
+
+    if (getClass() != obj.getClass())
+    {
+      return false;
+    }
+
+    final User other = (User) obj;
+
+    if ((this.displayName == null)
+        ? (other.displayName != null)
+        : !this.displayName.equals(other.displayName))
+    {
+      return false;
+    }
+
+    if ((this.mail == null)
+        ? (other.mail != null)
+        : !this.mail.equals(other.mail))
+    {
+      return false;
+    }
+
+    if ((this.name == null)
+        ? (other.name != null)
+        : !this.name.equals(other.name))
+    {
+      return false;
+    }
+
+    if ((this.password == null)
+        ? (other.password != null)
+        : !this.password.equals(other.password))
+    {
+      return false;
+    }
+
+    if ((this.type == null)
+        ? (other.type != null)
+        : !this.type.equals(other.type))
+    {
+      return false;
+    }
+
+    return true;
+  }
+
+  /**
+   * Method description
+   *
+   *
+   * @return
+   */
+  @Override
+  public int hashCode()
+  {
+    int hash = 7;
+
+    hash = 79 * hash + ((this.displayName != null)
+                        ? this.displayName.hashCode()
+                        : 0);
+    hash = 79 * hash + ((this.mail != null)
+                        ? this.mail.hashCode()
+                        : 0);
+    hash = 79 * hash + ((this.name != null)
+                        ? this.name.hashCode()
+                        : 0);
+    hash = 79 * hash + ((this.password != null)
+                        ? this.password.hashCode()
+                        : 0);
+    hash = 79 * hash + ((this.type != null)
+                        ? this.type.hashCode()
+                        : 0);
+
+    return hash;
+  }
+
   //~--- get methods ----------------------------------------------------------
 
   /**

scm-core/src/test/java/sonia/scm/user/UserHandlerTestBase.java

@@ -0,0 +1,328 @@
+/**
+ * Copyright (c) 2010, Sebastian Sdorra
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright notice,
+ *    this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright notice,
+ *    this list of conditions and the following disclaimer in the documentation
+ *    and/or other materials provided with the distribution.
+ * 3. Neither the name of SCM-Manager; nor the names of its
+ *    contributors may be used to endorse or promote products derived from this
+ *    software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * http://bitbucket.org/sdorra/scm-manager
+ *
+ */
+
+
+
+package sonia.scm.user;
+
+//~--- non-JDK imports --------------------------------------------------------
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
+
+import sonia.scm.SCMContextProvider;
+import sonia.scm.util.IOUtil;
+
+import static org.junit.Assert.*;
+
+import static org.mockito.Mockito.*;
+
+//~--- JDK imports ------------------------------------------------------------
+
+import java.io.File;
+import java.io.IOException;
+
+import java.util.Collection;
+import java.util.UUID;
+
+/**
+ *
+ * @author Sebastian Sdorra
+ */
+public abstract class UserHandlerTestBase
+{
+
+  /**
+   * Method description
+   *
+   *
+   * @return
+   */
+  public abstract UserHandler createUserHandler();
+
+  /**
+   * Method description
+   *
+   *
+   * @throws IOException
+   */
+  @After
+  public void tearDownTest() throws IOException
+  {
+    try
+    {
+      handler.close();
+    }
+    finally
+    {
+      IOUtil.delete(tempDirectory);
+    }
+  }
+
+  /**
+   * Method description
+   *
+   *
+   * @throws IOException
+   * @throws UserException
+   */
+  @Test
+  public void testCreate() throws UserException, IOException
+  {
+    User zaphod = getTestUser();
+
+    handler.create(zaphod);
+
+    User otherUser = handler.get("zaphod");
+
+    assertNotNull(otherUser);
+    assertUserEquals(zaphod, otherUser);
+  }
+
+  /**
+   * Method description
+   *
+   *
+   * @throws IOException
+   * @throws UserException
+   */
+  @Test(expected = UserAllreadyExistException.class)
+  public void testCreateExisting() throws UserException, IOException
+  {
+    User zaphod = getTestUser();
+
+    handler.create(zaphod);
+    assertNotNull(handler.get("zaphod"));
+
+    User sameUser = getTestUser();
+
+    handler.create(sameUser);
+  }
+
+  /**
+   * Method description
+   *
+   *
+   * @throws IOException
+   * @throws UserException
+   */
+  @Test
+  public void testDelete() throws UserException, IOException
+  {
+    User zaphod = getTestUser();
+
+    handler.create(zaphod);
+    assertNotNull(handler.get("zaphod"));
+    handler.delete(zaphod);
+    assertNull(handler.get("zaphod"));
+  }
+
+  /**
+   * Method description
+   *
+   *
+   * @throws IOException
+   * @throws UserException
+   */
+  @Test
+  public void testGet() throws UserException, IOException
+  {
+    User zaphod = getTestUser();
+
+    handler.create(zaphod);
+    assertNotNull(handler.get("zaphod"));
+    handler.get("");
+  }
+
+  /**
+   * Method description
+   *
+   *
+   * @throws IOException
+   * @throws UserException
+   */
+  @Test
+  public void testGetAll() throws UserException, IOException
+  {
+    User zaphod = getTestUser();
+
+    handler.create(zaphod);
+    assertNotNull(handler.get("zaphod"));
+
+    User trillian = new User("trillian", "Tricia McMillan",
+                             "tricia.mcmillan@hitchhiker.com");
+
+    handler.create(trillian);
+    assertNotNull(handler.get("trillian"));
+
+    boolean foundZaphod = false;
+    boolean foundTrillian = false;
+    Collection<User> users = handler.getAll();
+
+    assertNotNull(users);
+    assertFalse(users.isEmpty());
+    assertTrue(users.size() >= 2);
+
+    for (User u : users)
+    {
+      if (u.getName().equals("zaphod"))
+      {
+        foundZaphod = true;
+        assertUserEquals(zaphod, u);
+      }
+      else if (u.getName().equals("trillian"))
+      {
+        foundTrillian = true;
+        assertUserEquals(trillian, u);
+      }
+    }
+
+    assertTrue(foundZaphod);
+    assertTrue(foundTrillian);
+  }
+
+  /**
+   * Method description
+   *
+   *
+   * @throws IOException
+   * @throws UserException
+   */
+  @Test
+  public void testModify() throws UserException, IOException
+  {
+    User zaphod = getTestUser();
+
+    handler.create(zaphod);
+    assertNotNull(handler.get("zaphod"));
+    zaphod.setDisplayName("Tricia McMillan");
+    handler.modify(zaphod);
+
+    User otherUser = handler.get("zaphod");
+
+    assertNotNull(otherUser);
+    assertEquals(otherUser.getDisplayName(), "Tricia McMillan");
+  }
+
+  /**
+   * Method description
+   *
+   *
+   * @throws IOException
+   * @throws UserException
+   */
+  @Test(expected = UserException.class)
+  public void testModifyNotExisting() throws UserException, IOException
+  {
+    User zaphod = getTestUser();
+
+    handler.modify(zaphod);
+  }
+
+  /**
+   * Method description
+   *
+   *
+   * @throws IOException
+   * @throws UserException
+   */
+  @Test
+  public void testRefresh() throws UserException, IOException
+  {
+    User zaphod = getTestUser();
+
+    handler.create(zaphod);
+    assertNotNull(handler.get("zaphod"));
+    zaphod.setDisplayName("Tricia McMillan");
+    handler.refresh(zaphod);
+    assertEquals(zaphod.getDisplayName(), "Zaphod Beeblebrox");
+  }
+
+  //~--- set methods ----------------------------------------------------------
+
+  /**
+   * Method description
+   *
+   */
+  @Before
+  public void setUpTest()
+  {
+    tempDirectory = new File(System.getProperty("java.io.tmpdir"),
+                             UUID.randomUUID().toString());
+    assertTrue(tempDirectory.mkdirs());
+    handler = createUserHandler();
+
+    SCMContextProvider provider = mock(SCMContextProvider.class);
+
+    when(provider.getBaseDirectory()).thenReturn(tempDirectory);
+    handler.init(provider);
+  }
+
+  //~--- methods --------------------------------------------------------------
+
+  /**
+   * Method description
+   *
+   *
+   * @param user
+   * @param otherUser
+   */
+  private void assertUserEquals(User user, User otherUser)
+  {
+    assertEquals(user.getName(), otherUser.getName());
+    assertEquals(user.getDisplayName(), otherUser.getDisplayName());
+    assertEquals(user.getMail(), otherUser.getMail());
+    assertEquals(user.getPassword(), otherUser.getPassword());
+  }
+
+  //~--- get methods ----------------------------------------------------------
+
+  /**
+   * Method description
+   *
+   *
+   * @return
+   */
+  private User getTestUser()
+  {
+    return new User("zaphod", "Zaphod Beeblebrox",
+                    "zaphod.beeblebrox@hitchhiker.com");
+  }
+
+  //~--- fields ---------------------------------------------------------------
+
+  /** Field description */
+  private UserHandler handler;
+
+  /** Field description */
+  private File tempDirectory;
+}

scm-core/src/test/java/sonia/scm/user/XmlUserHandlerTest.java

@@ -0,0 +1,54 @@
+/**
+ * Copyright (c) 2010, Sebastian Sdorra
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright notice,
+ *    this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright notice,
+ *    this list of conditions and the following disclaimer in the documentation
+ *    and/or other materials provided with the distribution.
+ * 3. Neither the name of SCM-Manager; nor the names of its
+ *    contributors may be used to endorse or promote products derived from this
+ *    software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR ANY
+ * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+ * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * http://bitbucket.org/sdorra/scm-manager
+ *
+ */
+
+
+
+package sonia.scm.user;
+
+/**
+ *
+ * @author Sebastian Sdorra
+ */
+public class XmlUserHandlerTest extends UserHandlerTestBase
+{
+
+  /**
+   * Method description
+   *
+   *
+   * @return
+   */
+  @Override
+  public UserHandler createUserHandler()
+  {
+    return new XmlUserHandler();
+  }
+}