Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-10 23:45:44 +01:00
Code Issues Packages Projects Releases Activity

Encode revision for extension point to fix breaking change (#1585)

Browse Source 
Encode revision on extension points to fix a breaking change which slipped through with release 2.14.0.
This commit is contained in:
Eduard Heimbuch
2021-03-16 08:39:31 +01:00
committed by GitHub
parent 2ca4aa08de
commit 89e938c6d7
4 changed files with 27 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
scm-ui/ui-webapp/src/repos/sources/containers/Content.tsx
View File

@@ -141,7 +141,7 @@ class Content extends React.Component<Props, State> {
props={{
repository,
file,
revision,
revision: revision ? encodeURIComponent(revision) : "",
handleExtensionError: this.handleExtensionError
}}
renderAll={true}

10
scm-ui/ui-webapp/src/repos/sources/containers/SourceExtensions.tsx
View File

@@ -64,7 +64,15 @@ const SourceExtensions: FC<Props> = ({ repository, baseUrl }) => {
return <Loading />;
}
const extprops = { extension, repository, revision, path, sources, baseUrl };
const extprops = {
extension,
repository,
revision: revision ? encodeURIComponent(revision) : "",
path,
sources,
baseUrl
};
if (!binder.hasExtension(extensionPointName, extprops)) {
return <Notification type="warning">{t("sources.extension.notBound")}</Notification>;
}