improve exception handling

This commit is contained in:
Sebastian Sdorra
2011-05-12 19:36:10 +02:00
parent 8c2a383b2b
commit 883b9f1a3c
15 changed files with 486 additions and 146 deletions

View File

@@ -1,10 +1,10 @@
/**
* Copyright (c) 2010, Sebastian Sdorra
* All rights reserved.
*
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
*
*
* 1. Redistributions of source code must retain the above copyright notice,
* this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright notice,
@@ -13,7 +13,7 @@
* 3. Neither the name of SCM-Manager; nor the names of its
* contributors may be used to endorse or promote products derived from this
* software without specific prior written permission.
*
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
@@ -24,27 +24,34 @@
* ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
*
* http://bitbucket.org/sdorra/scm-manager
*
*
*/
package sonia.scm.client;
//~--- JDK imports ------------------------------------------------------------
import java.util.List;
/**
*
* @author Sebastian Sdorra
*
* @param <T>
*/
public interface ClientHandler<T>
{
/**
* Method description
*
*
* @param repository
*
* @param item
*/
public void create(T item);
@@ -60,7 +67,8 @@ public interface ClientHandler<T>
* Method description
*
*
* @param repository
*
* @param item
*/
public void delete(T item);
@@ -68,20 +76,13 @@ public interface ClientHandler<T>
* Method description
*
*
* @param repository
*
* @param item
*/
public void modify(T item);
//~--- get methods ----------------------------------------------------------
/**
* Method description
*
*
* @return
*/
public List<T> getAll();
/**
* Method description
*
@@ -91,4 +92,12 @@ public interface ClientHandler<T>
* @return
*/
public T get(String id);
/**
* Method description
*
*
* @return
*/
public List<T> getAll();
}

View File

@@ -98,9 +98,8 @@ public class ScmClient
*
* @return
*
* @throws ScmClientException
*/
private static ScmClientProvider getProvider() throws ScmClientException
private static ScmClientProvider getProvider()
{
if (provider == null)
{

View File

@@ -37,14 +37,36 @@ package sonia.scm.client;
*
* @author Sebastian Sdorra
*/
public class ScmClientException extends Exception
public class ScmClientException extends RuntimeException
{
/** Field description */
public static final int SC_FORBIDDEN = 403;
/** Field description */
public static final int SC_NOTFOUND = 404;
/** Field description */
public static final int SC_UNAUTHORIZED = 401;
/** Field description */
public static final int SC_UNKNOWN = -1;
/** Field description */
private static final long serialVersionUID = -2302107106896701393L;
//~--- constructors ---------------------------------------------------------
/**
* Constructs ...
*
*
* @param statusCode
*/
public ScmClientException() {}
public ScmClientException(int statusCode)
{
this.statusCode = statusCode;
}
/**
* Constructs ...
@@ -68,6 +90,20 @@ public class ScmClientException extends Exception
super(cause);
}
/**
* Constructs ...
*
*
*
* @param statusCode
* @param message
*/
public ScmClientException(int statusCode, String message)
{
super(message);
this.statusCode = statusCode;
}
/**
* Constructs ...
*
@@ -79,4 +115,60 @@ public class ScmClientException extends Exception
{
super(message, cause);
}
//~--- get methods ----------------------------------------------------------
/**
* Method description
*
*
* @return
*/
public String getContent()
{
return content;
}
/**
* Method description
*
*
* @return
*/
public int getStatusCode()
{
return statusCode;
}
//~--- set methods ----------------------------------------------------------
/**
* Method description
*
*
* @param content
*/
public void setContent(String content)
{
this.content = content;
}
/**
* Method description
*
*
* @param statusCode
*/
public void setStatusCode(int statusCode)
{
this.statusCode = statusCode;
}
//~--- fields ---------------------------------------------------------------
/** Field description */
private String content;
/** Field description */
private int statusCode = SC_UNKNOWN;
}

View File

@@ -50,9 +50,7 @@ public interface ScmClientProvider
*
* @return
*
* @throws ScmClientException
*/
public ScmClientSession createSession(String url, String username,
String password)
throws ScmClientException;
String password);
}

View File

@@ -50,6 +50,15 @@ import java.io.Closeable;
public interface ScmClientSession extends Closeable
{
/**
* Method description
*
*/
@Override
public void close();
//~--- get methods ----------------------------------------------------------
/**
* Method description
*

View File

@@ -0,0 +1,67 @@
/**
* Copyright (c) 2010, Sebastian Sdorra
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
*
* 1. Redistributions of source code must retain the above copyright notice,
* this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright notice,
* this list of conditions and the following disclaimer in the documentation
* and/or other materials provided with the distribution.
* 3. Neither the name of SCM-Manager; nor the names of its
* contributors may be used to endorse or promote products derived from this
* software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR ANY
* DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
* ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
* http://bitbucket.org/sdorra/scm-manager
*
*/
package sonia.scm.client;
/**
*
* @author Sebastian Sdorra
*/
public class ScmForbiddenException extends ScmClientException
{
/** Field description */
private static final long serialVersionUID = 3937346624508458660L;
//~--- constructors ---------------------------------------------------------
/**
* Constructs ...
*
*/
public ScmForbiddenException()
{
super(SC_FORBIDDEN);
}
/**
* Constructs ...
*
*
* @param message
*/
public ScmForbiddenException(String message)
{
super(SC_FORBIDDEN, message);
}
}

View File

@@ -37,4 +37,31 @@ package sonia.scm.client;
*
* @author Sebastian Sdorra
*/
public class UnauthorizedException extends ScmClientException {}
public class ScmNotFoundException extends ScmClientException
{
/** Field description */
private static final long serialVersionUID = -7015126639998723954L;
//~--- constructors ---------------------------------------------------------
/**
* Constructs ...
*
*/
public ScmNotFoundException()
{
super(SC_NOTFOUND);
}
/**
* Constructs ...
*
*
* @param message
*/
public ScmNotFoundException(String message)
{
super(SC_NOTFOUND, message);
}
}

View File

@@ -0,0 +1,67 @@
/**
* Copyright (c) 2010, Sebastian Sdorra
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
*
* 1. Redistributions of source code must retain the above copyright notice,
* this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright notice,
* this list of conditions and the following disclaimer in the documentation
* and/or other materials provided with the distribution.
* 3. Neither the name of SCM-Manager; nor the names of its
* contributors may be used to endorse or promote products derived from this
* software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR ANY
* DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
* ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
* http://bitbucket.org/sdorra/scm-manager
*
*/
package sonia.scm.client;
/**
*
* @author Sebastian Sdorra
*/
public class ScmUnauthorizedException extends ScmClientException
{
/** Field description */
private static final long serialVersionUID = 4398907424134588809L;
//~--- constructors ---------------------------------------------------------
/**
* Constructs ...
*
*/
public ScmUnauthorizedException()
{
super(SC_UNAUTHORIZED);
}
/**
* Constructs ...
*
*
* @param message
*/
public ScmUnauthorizedException(String message)
{
super(SC_UNAUTHORIZED, message);
}
}