Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-17 02:31:14 +01:00
Code Issues Packages Projects Releases Activity

Cleanup

Browse Source
This commit is contained in:
René Pfeuffer
2019-05-06 16:45:35 +02:00
parent 0099740a22
commit 8645890758
2 changed files with 40 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
scm-webapp/src/main/java/sonia/scm/security/DefaultAuthorizationCollector.java
View File

@@ -201,7 +201,7 @@ public class DefaultAuthorizationCollector implements AuthorizationCollector
{ {
hasPermission = isUserPermitted(user, groups, permission); hasPermission = isUserPermitted(user, groups, permission);
if (hasPermission) { if (hasPermission) {
addRepositoryPermission(builder, repository, user, hasPermission, permission); addRepositoryPermission(builder, repository, user, permission);
} }
} }
@@ -217,7 +217,7 @@ public class DefaultAuthorizationCollector implements AuthorizationCollector
} }
} }
private void addRepositoryPermission(Builder<String> builder, Repository repository, User user, boolean hasPermission, RepositoryPermission permission) { private void addRepositoryPermission(Builder<String> builder, Repository repository, User user, RepositoryPermission permission) {
Collection<String> verbs = getVerbs(permission); Collection<String> verbs = getVerbs(permission);
if (!verbs.isEmpty()) if (!verbs.isEmpty())
{ {
@@ -237,7 +237,12 @@ public class DefaultAuthorizationCollector implements AuthorizationCollector
} }
private Collection<String> getVerbsForRole(String roleName) { private Collection<String> getVerbsForRole(String roleName) {
return repositoryPermissionProvider.availableRoles().stream().filter(role -> roleName.equals(role.getName())).findFirst().orElseThrow(() -> new RuntimeException()).getVerbs(); return repositoryPermissionProvider.availableRoles()
.stream()
.filter(role -> roleName.equals(role.getName()))
.findFirst()
.orElseThrow(() -> new IllegalStateException("unknown role: " + roleName))
.getVerbs();
} }
private AuthorizationInfo createAuthorizationInfo(User user, GroupNames groups) { private AuthorizationInfo createAuthorizationInfo(User user, GroupNames groups) {

35
scm-webapp/src/test/java/sonia/scm/security/DefaultAuthorizationCollectorTest.java
View File

@@ -58,7 +58,10 @@ import sonia.scm.repository.RepositoryTestData;
import sonia.scm.user.User; import sonia.scm.user.User;
import sonia.scm.user.UserTestData; import sonia.scm.user.UserTestData;
import java.util.Collections;
import static java.util.Arrays.asList; import static java.util.Arrays.asList;
import static java.util.Collections.singletonList;
import static org.hamcrest.Matchers.containsInAnyOrder; import static org.hamcrest.Matchers.containsInAnyOrder;
import static org.hamcrest.Matchers.hasSize; import static org.hamcrest.Matchers.hasSize;
import static org.hamcrest.Matchers.nullValue; import static org.hamcrest.Matchers.nullValue;
@@ -203,9 +206,9 @@ public class DefaultAuthorizationCollectorTest {
public void testCollectWithRepositoryRolePermissions() { public void testCollectWithRepositoryRolePermissions() {
when(repositoryPermissionProvider.availableRoles()).thenReturn( when(repositoryPermissionProvider.availableRoles()).thenReturn(
asList( asList(
new RepositoryRole("user role", asList("user"), "xml"), new RepositoryRole("user role", singletonList("user"), "xml"),
new RepositoryRole("group role", asList("group"), "xml"), new RepositoryRole("group role", singletonList("group"), "xml"),
new RepositoryRole("system role", asList("system"), "system") new RepositoryRole("system role", singletonList("system"), "system")
)); ));
String group = "heart-of-gold-crew"; String group = "heart-of-gold-crew";
@@ -236,6 +239,32 @@ public class DefaultAuthorizationCollectorTest {
"user:read:trillian")); "user:read:trillian"));
} }
/**
* Tests {@link AuthorizationCollector#collect(PrincipalCollection)} with repository roles.
*/
@Test(expected = IllegalStateException.class)
@SubjectAware(
configuration = "classpath:sonia/scm/shiro-001.ini"
)
public void testCollectWithUnknownRepositoryRole() {
when(repositoryPermissionProvider.availableRoles()).thenReturn(
singletonList(
new RepositoryRole("something", singletonList("something"), "xml")
));
String group = "heart-of-gold-crew";
authenticate(UserTestData.createTrillian(), group);
Repository heartOfGold = RepositoryTestData.createHeartOfGold();
heartOfGold.setId("one");
heartOfGold.setPermissions(singletonList(
new RepositoryPermission("trillian", "unknown", false)
));
when(repositoryDAO.getAll()).thenReturn(Lists.newArrayList(heartOfGold));
// execute and assert
AuthorizationInfo authInfo = collector.collect();
}
/** /**
* Tests {@link AuthorizationCollector#collect(PrincipalCollection)} ()} with global permissions. * Tests {@link AuthorizationCollector#collect(PrincipalCollection)} ()} with global permissions.
*/ */