Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-10 15:35:49 +01:00
Code Issues Packages Projects Releases Activity

add error handling for fetching users

Browse Source
This commit is contained in:
Maren Süwer
2018-07-19 11:57:59 +02:00
parent 9593a18a55
commit 8562b9d65e
3 changed files with 43 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
scm-ui/src/users/modules/users.js
View File

@@ -46,11 +46,13 @@ function requestUsers() {
};
}
function failedToFetchUsers(url: string, err: Error) {
export function failedToFetchUsers(url: string, error: Error) {
return {
type: FETCH_USERS_FAILURE,
payload: err,
url
payload: {
error,
url
}
};
}
@@ -77,12 +79,9 @@ export function fetchUsers() {
.then(data => {
dispatch(fetchUsersSuccess(data));
})
.catch(err => {
if (err === NOT_FOUND_ERROR) {
dispatch(usersNotFound(USERS_URL));
} else {
dispatch(failedToFetchUsers(USERS_URL, err));
}
.catch(cause => {
const error = new Error(`could not fetch users: ${cause.message}`);
dispatch(failedToFetchUsers(USERS_URL, error));
});
};
}
@@ -120,12 +119,9 @@ export function fetchUser(name: string) {
.then(data => {
dispatch(fetchUserSuccess(data));
})
.catch(err => {
if (err === NOT_FOUND_ERROR) {
dispatch(usersNotFound(userUrl));
} else {
dispatch(failedToFetchUsers(userUrl, err));
}
.catch(cause => {
const error = new Error(`could not fetch user: ${cause.message}`);
dispatch(failedToFetchUsers(USERS_URL, error));
});
};
}
@@ -386,6 +382,14 @@ export default function reducer(state: any = {}, action: any = {}) {
usersByNames: newUserByNames
}
case FETCH_USERS_FAILURE:
return {
...state,
users: {
...state.users,
loading: false,
error: action.payload.error
}
};
case DELETE_USER_FAILURE:
const newState = reduceUsersByNames(state, action.payload.user.name, {
loading: false,