reauthenticate user on mercurial hooks

This commit is contained in:
Sebastian Sdorra
2011-10-15 15:55:17 +02:00
parent 6328a14654
commit 84f63e94c0
4 changed files with 106 additions and 5 deletions

View File

@@ -49,8 +49,10 @@ import sonia.scm.repository.HgRepositoryHookEvent;
import sonia.scm.repository.RepositoryHookType;
import sonia.scm.repository.RepositoryManager;
import sonia.scm.repository.RepositoryNotFoundException;
import sonia.scm.security.CipherUtil;
import sonia.scm.util.HttpUtil;
import sonia.scm.util.Util;
import sonia.scm.web.security.WebSecurityContext;
//~--- JDK imports ------------------------------------------------------------
@@ -81,6 +83,9 @@ public class HgHookCallbackServlet extends HttpServlet
/** Field description */
private static final String PARAM_CHALLENGE = "challenge";
/** Field description */
private static final String PARAM_CREDENTIALS = "credentials";
/** Field description */
private static final String PARAM_NODE = "node";
@@ -102,17 +107,19 @@ public class HgHookCallbackServlet extends HttpServlet
* @param handler
* @param hookManager
* @param contextProvider
* @param securityContextProvider
*/
@Inject
public HgHookCallbackServlet(RepositoryManager repositoryManager,
HgRepositoryHandler handler,
HgHookManager hookManager,
Provider<HgContext> contextProvider)
public HgHookCallbackServlet(
RepositoryManager repositoryManager, HgRepositoryHandler handler,
HgHookManager hookManager, Provider<HgContext> contextProvider,
Provider<WebSecurityContext> securityContextProvider)
{
this.repositoryManager = repositoryManager;
this.handler = handler;
this.hookManager = hookManager;
this.contextProvider = contextProvider;
this.securityContextProvider = securityContextProvider;
}
//~--- methods --------------------------------------------------------------
@@ -147,6 +154,13 @@ public class HgHookCallbackServlet extends HttpServlet
if (Util.isNotEmpty(node))
{
String credentials = request.getParameter(PARAM_CREDENTIALS);
if (Util.isNotEmpty(credentials))
{
authenticate(request, response, credentials);
}
hookCallback(response, repositoryId, type, challenge, node);
}
else if (logger.isDebugEnabled())
@@ -170,6 +184,40 @@ public class HgHookCallbackServlet extends HttpServlet
}
}
/**
* Method description
*
*
* @param request
* @param response
* @param credentials
*/
private void authenticate(HttpServletRequest request,
HttpServletResponse response, String credentials)
{
try
{
credentials = CipherUtil.getInstance().decode(credentials);
if (Util.isNotEmpty(credentials))
{
String[] credentialsArray = credentials.split(":");
if (credentialsArray.length >= 2)
{
WebSecurityContext context = securityContextProvider.get();
context.authenticate(request, response, credentialsArray[0],
credentialsArray[1]);
}
}
}
catch (Exception ex)
{
logger.error("could not authenticate user", ex);
}
}
/**
* Method description
*
@@ -281,4 +329,7 @@ public class HgHookCallbackServlet extends HttpServlet
/** Field description */
private RepositoryManager repositoryManager;
/** Field description */
private Provider<WebSecurityContext> securityContextProvider;
}