Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-11 07:55:47 +01:00
Code Issues Packages Projects Releases Activity

use a new permission array since state think it stays the same if splice is used

Browse Source
This commit is contained in:
Maren Süwer
2018-09-03 15:45:34 +02:00
parent 0f78ce9d3a
commit 8362752370
3 changed files with 17 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
scm-ui/src/permissions/containers/Permissions.js
View File

@@ -10,7 +10,9 @@ import {
getPermissionsOfRepo,
hasCreatePermission,
createPermission,
isCreatePermissionPending, getCreatePermissionFailure, createPermissionReset
isCreatePermissionPending,
getCreatePermissionFailure,
createPermissionReset
} from "../modules/permissions";
import Loading from "../../components/Loading";
import ErrorPage from "../../components/ErrorPage";
@@ -49,7 +51,12 @@ type Props = {
class Permissions extends React.Component<Props> {
componentDidMount() {
const { fetchPermissions, namespace, repoName, createPermissionReset } = this.props;
const {
fetchPermissions,
namespace,
repoName,
createPermissionReset
} = this.props;
createPermissionReset(namespace, repoName);
fetchPermissions(namespace, repoName);
@@ -71,7 +78,6 @@ class Permissions extends React.Component<Props> {
loadingCreatePermission,
hasPermissionToCreate
} = this.props;
if (error) {
return (
<ErrorPage
@@ -132,7 +138,9 @@ class Permissions extends React.Component<Props> {
const mapStateToProps = (state, ownProps) => {
const namespace = ownProps.namespace;
const repoName = ownProps.repoName;
const error = getFetchPermissionsFailure(state, namespace, repoName) || getCreatePermissionFailure(state, namespace, repoName);
const error =
getFetchPermissionsFailure(state, namespace, repoName) ||
getCreatePermissionFailure(state, namespace, repoName);
const loading = isFetchPermissionsPending(state, namespace, repoName);
const permissions = getPermissionsOfRepo(state, namespace, repoName);
const loadingCreatePermission = isCreatePermissionPending(
@@ -165,10 +173,7 @@ const mapDispatchToProps = dispatch => {
) => {
dispatch(createPermission(permission, namespace, repoName, callback));
},
createPermissionReset: (
namespace: string,
repoName: string
) => {
createPermissionReset: (namespace: string, repoName: string) => {
dispatch(createPermissionReset(namespace, repoName));
}
};