Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-14 17:26:22 +01:00
Code Issues Packages Projects Releases Activity

improve LoggingFilter

Browse Source
This commit is contained in:
Sebastian Sdorra
2010-11-13 14:09:07 +01:00
parent 65d33088b1
commit 82f9284b4d
1 changed files with 31 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

74
scm-web-api/src/main/java/sonia/scm/web/filter/LoggingFilter.java
View File

@@ -29,6 +29,8 @@
* *
*/ */
package sonia.scm.web.filter; package sonia.scm.web.filter;
//~--- non-JDK imports -------------------------------------------------------- //~--- non-JDK imports --------------------------------------------------------
@@ -117,16 +119,16 @@ public class LoggingFilter extends HttpFilter
private void logRequest(LoggingHttpServletRequest request) private void logRequest(LoggingHttpServletRequest request)
{ {
logger.debug("**************** request ****************"); logger.debug("**************** request ****************");
logger.debug("Info: Request-Uri = ".concat(request.getRequestURI())); logger.debug("Info: Request-Uri = {}", request.getRequestURI());
logger.debug("Info: Remote-Addr = ".concat(request.getRemoteAddr())); logger.debug("Info: Remote-Addr = {}", request.getRemoteAddr());
logger.debug( logger.debug("Info: Remote-User = {}",
"Info: Content-Size = ".concat( Util.nonNull(request.getRemoteUser()));
Integer.toString(request.getContentLength()))); logger.debug("Info: Content-Size = {}",
logger.debug( Integer.toString(request.getContentLength()));
"Info: Content-Type = ".concat(Util.nonNull(request.getContentType()))); logger.debug("Info: Content-Type = {}",
logger.debug("Info: Method = ".concat(request.getMethod())); Util.nonNull(request.getContentType()));
logger.debug( logger.debug("Info: Method = {}", request.getMethod());
"Info: AuthType = ".concat(Util.nonNull(request.getAuthType()))); logger.debug("Info: AuthType = {}", Util.nonNull(request.getAuthType()));
Enumeration headers = request.getHeaderNames(); Enumeration headers = request.getHeaderNames();
@@ -134,9 +136,7 @@ public class LoggingFilter extends HttpFilter
{ {
String header = (String) headers.nextElement(); String header = (String) headers.nextElement();
logger.debug( logger.debug("Header: {} = {}", header, request.getHeader(header));
"Header: ".concat(header).concat(" = ").concat(
request.getHeader(header)));
} }
Cookie[] cookies = request.getCookies(); Cookie[] cookies = request.getCookies();
@@ -145,9 +145,7 @@ public class LoggingFilter extends HttpFilter
{ {
for (Cookie cookie : cookies) for (Cookie cookie : cookies)
{ {
logger.debug( logger.debug("Cookie: {} = {}", cookie.getName(), cookie.getValue());
"Cookie: ".concat(cookie.getName()).concat(" = ").concat(
cookie.getValue()));
} }
} }
@@ -159,9 +157,8 @@ public class LoggingFilter extends HttpFilter
{ {
String parameter = (String) parameters.nextElement(); String parameter = (String) parameters.nextElement();
logger.debug( logger.debug("Parameter: {} = {}", parameter,
"Parameter: ".concat(parameter).concat(" = ").concat( request.getParameter(parameter));
request.getParameter(parameter)));
} }
} }
@@ -173,15 +170,14 @@ public class LoggingFilter extends HttpFilter
{ {
String attribute = (String) attributes.nextElement(); String attribute = (String) attributes.nextElement();
logger.debug( logger.debug("Attribute: {} = {}", attribute,
"Attribute: ".concat(attribute).concat(" = ").concat( request.getAttribute(attribute).toString());
request.getAttribute(attribute).toString()));
} }
} }
HttpSession session = request.getSession(true); HttpSession session = request.getSession(true);
logger.debug("Session-New: ".concat(Boolean.toString(session.isNew()))); logger.debug("Session-New: {}", Boolean.toString(session.isNew()));
Enumeration sAttributes = session.getAttributeNames(); Enumeration sAttributes = session.getAttributeNames();
@@ -191,9 +187,8 @@ public class LoggingFilter extends HttpFilter
{ {
String sAttribute = (String) sAttributes.nextElement(); String sAttribute = (String) sAttributes.nextElement();
logger.debug( logger.debug("Session-Attribute: {} = {}", sAttribute,
"Session-Attribute: ".concat(sAttribute).concat(" = ").concat( request.getSession().getAttribute(sAttribute).toString());
request.getSession().getAttribute(sAttribute).toString()));
} }
} }
} }
@@ -207,30 +202,23 @@ public class LoggingFilter extends HttpFilter
private void logResponse(LoggingHttpServletResponse response) private void logResponse(LoggingHttpServletResponse response)
{ {
logger.debug("**************** response ****************"); logger.debug("**************** response ****************");
logger.debug( logger.debug("status code = {}",
"status code = ".concat(Integer.toString(response.getStatusCode()))); Integer.toString(response.getStatusCode()));
logger.debug( logger.debug("status message = {}",
"status message = ".concat(Util.nonNull(response.getStatusMessage()))); Util.nonNull(response.getStatusMessage()));
logger.debug( logger.debug("charset = {}", Util.nonNull(response.getCharacterEncoding()));
"charset = ".concat(Util.nonNull(response.getCharacterEncoding()))); logger.debug("content-type = {}", Util.nonNull(response.getContentType()));
logger.debug( logger.debug("content-length = {}",
"content-type = ".concat(Util.nonNull(response.getContentType()))); Integer.toString(response.getContentLength()));
logger.debug(
"content-length = ".concat(
Integer.toString(response.getContentLength())));
for (Cookie cookie : response.getCookies()) for (Cookie cookie : response.getCookies())
{ {
logger.debug( logger.debug("Cookie: {} = {}", cookie.getName(), cookie.getValue());
"Cookie: ".concat(cookie.getName()).concat(" = ").concat(
cookie.getValue()));
} }
for (Entry<String, String> header : response.getHeaders().entrySet()) for (Entry<String, String> header : response.getHeaders().entrySet())
{ {
logger.debug( logger.debug("Header: {} = {}", header.getKey(), header.getValue());
"Header: ".concat(header.getKey()).concat(" = ").concat(
header.getValue()));
} }
} }