added validation to SimpleRepositoryConfig

This commit is contained in:
Sebastian Sdorra
2010-11-25 18:29:27 +01:00
parent c036b7ac7c
commit 823c7e0bd4
3 changed files with 37 additions and 2 deletions

View File

@@ -33,6 +33,10 @@
package sonia.scm.repository;
//~--- non-JDK imports --------------------------------------------------------
import sonia.scm.util.Util;
//~--- JDK imports ------------------------------------------------------------
import javax.xml.bind.annotation.XmlRootElement;
@@ -75,6 +79,19 @@ public class HgConfig extends SimpleRepositoryConfig
return pythonBinary;
}
/**
* Method description
*
*
* @return
*/
@Override
public boolean isValid()
{
return super.isValid() && Util.isNotEmpty(hgBinary)
&& Util.isNotEmpty(pythonBinary);
}
//~--- set methods ----------------------------------------------------------
/**

View File

@@ -193,7 +193,7 @@ public abstract class AbstractRepositoryHandler<C extends SimpleRepositoryConfig
@Override
public boolean isConfigured()
{
return config != null;
return (config != null) && config.isValid();
}
//~--- set methods ----------------------------------------------------------

View File

@@ -29,8 +29,14 @@
*
*/
package sonia.scm.repository;
//~--- non-JDK imports --------------------------------------------------------
import sonia.scm.Validateable;
//~--- JDK imports ------------------------------------------------------------
import java.io.File;
@@ -39,7 +45,7 @@ import java.io.File;
*
* @author Sebastian Sdorra
*/
public class SimpleRepositoryConfig
public class SimpleRepositoryConfig implements Validateable
{
/**
@@ -53,6 +59,18 @@ public class SimpleRepositoryConfig
return repositoryDirectory;
}
/**
* Method description
*
*
* @return
*/
@Override
public boolean isValid()
{
return repositoryDirectory != null;
}
//~--- set methods ----------------------------------------------------------
/**