Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-10 23:45:44 +01:00
Code Issues Packages Projects Releases Activity

do not fail if the description is empty

Browse Source
This commit is contained in:
Sebastian Sdorra
2018-10-24 10:25:50 +02:00
parent e675c4358a
commit 7fff5a62c9
2 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
scm-ui/src/repos/components/changesets/changesets.js
View File

@@ -4,17 +4,18 @@ export type Description = {
message: string message: string
}; };
export function parseDescription(description: string): Description { export function parseDescription(description?: string): Description {
const lineBreak = description.indexOf("\n"); const desc = description ? description : "";
const lineBreak = desc.indexOf("\n");
let title; let title;
let message = ""; let message = "";
if (lineBreak > 0) { if (lineBreak > 0) {
title = description.substring(0, lineBreak); title = desc.substring(0, lineBreak);
message = description.substring(lineBreak + 1); message = desc.substring(lineBreak + 1);
} else { } else {
title = description; title = desc;
} }
return { return {

6
scm-ui/src/repos/components/changesets/changesets.test.js
View File

@@ -13,4 +13,10 @@ describe("parseDescription tests", () => {
const desc = parseDescription("Hello Trillian"); const desc = parseDescription("Hello Trillian");
expect(desc.title).toBe("Hello Trillian"); expect(desc.title).toBe("Hello Trillian");
}); });
it("should return an empty description for undefined", () => {
const desc = parseDescription();
expect(desc.title).toBe("");
expect(desc.message).toBe("");
});
}); });