Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-13 08:55:44 +01:00
Code Issues Packages Projects Releases Activity

remove downloaded artifact on error

Browse Source
This commit is contained in:
Sebastian Sdorra
2019-08-21 07:56:52 +02:00
parent e0fa09fd04
commit 7ef4b30027
2 changed files with 30 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
scm-webapp/src/main/java/sonia/scm/plugin/PluginInstaller.java
View File

@@ -27,25 +27,35 @@ class PluginInstaller {
}
public PendingPluginInstallation install(AvailablePlugin plugin) {
Path file = null;
try (HashingInputStream input = new HashingInputStream(Hashing.sha256(), download(plugin))) {
Path file = createFile(plugin);
file = createFile(plugin);
Files.copy(input, file);
verifyChecksum(plugin, input.hash());
// TODO clean up in case of error
verifyChecksum(plugin, input.hash(), file);
return new PendingPluginInstallation(plugin, file);
} catch (IOException ex) {
cleanup(file);
throw new PluginDownloadException("failed to download plugin", ex);
}
}
private void verifyChecksum(AvailablePlugin plugin, HashCode hash) {
private void cleanup(Path file) {
try {
if (file != null) {
Files.deleteIfExists(file);
}
} catch (IOException e) {
throw new PluginInstallException("failed to cleanup, after broken installation");
}
}
private void verifyChecksum(AvailablePlugin plugin, HashCode hash, Path file) {
Optional<String> checksum = plugin.getDescriptor().getChecksum();
if (checksum.isPresent()) {
String calculatedChecksum = hash.toString();
if (!checksum.get().equalsIgnoreCase(calculatedChecksum)) {
cleanup(file);
throw new PluginChecksumMismatchException(
String.format("downloaded plugin checksum %s does not match expected %s", calculatedChecksum, checksum.get())
);