mirror of
https://github.com/scm-manager/scm-manager.git
synced 2025-11-09 15:05:44 +01:00
use web-resources to deliver web resources from the WebResourceServlet
This commit is contained in:
@@ -237,6 +237,12 @@
|
|||||||
<version>${mustache.version}</version>
|
<version>${mustache.version}</version>
|
||||||
</dependency>
|
</dependency>
|
||||||
|
|
||||||
|
<dependency>
|
||||||
|
<groupId>com.github.sdorra</groupId>
|
||||||
|
<artifactId>web-resources</artifactId>
|
||||||
|
<version>1.0.1</version>
|
||||||
|
</dependency>
|
||||||
|
|
||||||
<dependency>
|
<dependency>
|
||||||
<groupId>com.github.sdorra</groupId>
|
<groupId>com.github.sdorra</groupId>
|
||||||
<artifactId>spotter-core</artifactId>
|
<artifactId>spotter-core</artifactId>
|
||||||
@@ -248,6 +254,7 @@
|
|||||||
<artifactId>tika-core</artifactId>
|
<artifactId>tika-core</artifactId>
|
||||||
<version>1.18</version>
|
<version>1.18</version>
|
||||||
</dependency>
|
</dependency>
|
||||||
|
|
||||||
<!-- test scope -->
|
<!-- test scope -->
|
||||||
|
|
||||||
<dependency>
|
<dependency>
|
||||||
|
|||||||
@@ -1,7 +1,7 @@
|
|||||||
package sonia.scm;
|
package sonia.scm;
|
||||||
|
|
||||||
|
import com.github.sdorra.webresources.WebResourceSender;
|
||||||
import com.google.common.annotations.VisibleForTesting;
|
import com.google.common.annotations.VisibleForTesting;
|
||||||
import com.google.common.io.Resources;
|
|
||||||
import org.slf4j.Logger;
|
import org.slf4j.Logger;
|
||||||
import org.slf4j.LoggerFactory;
|
import org.slf4j.LoggerFactory;
|
||||||
import sonia.scm.filter.WebElement;
|
import sonia.scm.filter.WebElement;
|
||||||
@@ -15,7 +15,6 @@ import javax.servlet.http.HttpServlet;
|
|||||||
import javax.servlet.http.HttpServletRequest;
|
import javax.servlet.http.HttpServletRequest;
|
||||||
import javax.servlet.http.HttpServletResponse;
|
import javax.servlet.http.HttpServletResponse;
|
||||||
import java.io.IOException;
|
import java.io.IOException;
|
||||||
import java.io.OutputStream;
|
|
||||||
import java.net.URL;
|
import java.net.URL;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@@ -27,6 +26,7 @@ import java.net.URL;
|
|||||||
@WebElement(value = WebResourceServlet.PATTERN, regex = true)
|
@WebElement(value = WebResourceServlet.PATTERN, regex = true)
|
||||||
public class WebResourceServlet extends HttpServlet {
|
public class WebResourceServlet extends HttpServlet {
|
||||||
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* exclude api requests and the old frontend servlets.
|
* exclude api requests and the old frontend servlets.
|
||||||
*
|
*
|
||||||
@@ -37,6 +37,11 @@ public class WebResourceServlet extends HttpServlet {
|
|||||||
|
|
||||||
private static final Logger LOG = LoggerFactory.getLogger(WebResourceServlet.class);
|
private static final Logger LOG = LoggerFactory.getLogger(WebResourceServlet.class);
|
||||||
|
|
||||||
|
private final WebResourceSender sender = WebResourceSender.create()
|
||||||
|
.withGZIP()
|
||||||
|
.withGZIPMinLength(512)
|
||||||
|
.withBufferSize(16384);
|
||||||
|
|
||||||
private final UberWebResourceLoader webResourceLoader;
|
private final UberWebResourceLoader webResourceLoader;
|
||||||
private final PushStateDispatcher pushStateDispatcher;
|
private final PushStateDispatcher pushStateDispatcher;
|
||||||
|
|
||||||
@@ -53,7 +58,7 @@ public class WebResourceServlet extends HttpServlet {
|
|||||||
LOG.trace("try to load {}", uri);
|
LOG.trace("try to load {}", uri);
|
||||||
URL url = webResourceLoader.getResource(uri);
|
URL url = webResourceLoader.getResource(uri);
|
||||||
if (url != null) {
|
if (url != null) {
|
||||||
serveResource(response, url);
|
serveResource(request, response, url);
|
||||||
} else {
|
} else {
|
||||||
dispatch(request, response, uri);
|
dispatch(request, response, uri);
|
||||||
}
|
}
|
||||||
@@ -72,10 +77,9 @@ public class WebResourceServlet extends HttpServlet {
|
|||||||
return HttpUtil.getStrippedURI(request);
|
return HttpUtil.getStrippedURI(request);
|
||||||
}
|
}
|
||||||
|
|
||||||
private void serveResource(HttpServletResponse response, URL url) {
|
private void serveResource(HttpServletRequest request, HttpServletResponse response, URL url) {
|
||||||
// TODO lastModifiedDate, if-... ???
|
try {
|
||||||
try (OutputStream output = response.getOutputStream()) {
|
sender.resource(url).send(request, response);
|
||||||
Resources.copy(url, output);
|
|
||||||
} catch (IOException ex) {
|
} catch (IOException ex) {
|
||||||
LOG.warn("failed to serve resource: {}", url);
|
LOG.warn("failed to serve resource: {}", url);
|
||||||
response.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
|
response.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
|
||||||
|
|||||||
@@ -22,7 +22,7 @@ import java.io.IOException;
|
|||||||
import static org.junit.Assert.*;
|
import static org.junit.Assert.*;
|
||||||
import static org.mockito.Mockito.*;
|
import static org.mockito.Mockito.*;
|
||||||
|
|
||||||
@RunWith(MockitoJUnitRunner.class)
|
@RunWith(MockitoJUnitRunner.Silent.class)
|
||||||
public class WebResourceServletTest {
|
public class WebResourceServletTest {
|
||||||
|
|
||||||
@Rule
|
@Rule
|
||||||
|
|||||||
Reference in New Issue
Block a user