first try on delete user

This commit is contained in:
Florian Scholdei
2019-01-18 13:42:11 +01:00
parent 8f340ceab0
commit 71fc38dd1d
6 changed files with 17 additions and 14 deletions

View File

@@ -27,7 +27,8 @@
}
},
"user-form": {
"submit": "Submit"
"submit": "Submit",
"deleteUser": "Delete User"
},
"add-user": {
"title": "Create User",

View File

@@ -2,7 +2,7 @@
import React from "react";
import { translate } from "react-i18next";
import type { User } from "@scm-manager/ui-types";
import { NavAction, confirmAlert } from "@scm-manager/ui-components";
import { DeleteButton, confirmAlert } from "@scm-manager/ui-components";
type Props = {
user: User,
@@ -11,7 +11,7 @@ type Props = {
deleteUser: (user: User) => void
};
class DeleteUserNavLink extends React.Component<Props> {
class DeleteUser extends React.Component<Props> {
static defaultProps = {
confirmDialog: true
};
@@ -49,8 +49,8 @@ class DeleteUserNavLink extends React.Component<Props> {
if (!this.isDeletable()) {
return null;
}
return <NavAction label={t("delete-user-button.label")} action={action} />;
return <DeleteButton label={t("user-form.deleteUser")} action={action} />;
}
}
export default translate("users")(DeleteUserNavLink);
export default translate("users")(DeleteUser);

View File

@@ -1,8 +1,8 @@
import React from "react";
import { mount, shallow } from "enzyme";
import "../../../tests/enzyme";
import "../../tests/enzyme";
import "../../../tests/i18n";
import DeleteUserNavLink from "./DeleteUserNavLink";
import DeleteUser from "../DeleteUser";
import { confirmAlert } from "@scm-manager/ui-components";
jest.mock("@scm-manager/ui-components", () => ({
@@ -10,14 +10,14 @@ jest.mock("@scm-manager/ui-components", () => ({
NavAction: require.requireActual("@scm-manager/ui-components").NavAction
}));
describe("DeleteUserNavLink", () => {
describe("DeleteUser", () => {
it("should render nothing, if the delete link is missing", () => {
const user = {
_links: {}
};
const navLink = shallow(
<DeleteUserNavLink user={user} deleteUser={() => {}} />
<DeleteUser user={user} deleteUser={() => {}} />
);
expect(navLink.text()).toBe("");
});
@@ -32,7 +32,7 @@ describe("DeleteUserNavLink", () => {
};
const navLink = mount(
<DeleteUserNavLink user={user} deleteUser={() => {}} />
<DeleteUser user={user} deleteUser={() => {}} />
);
expect(navLink.text()).not.toBe("");
});
@@ -47,7 +47,7 @@ describe("DeleteUserNavLink", () => {
};
const navLink = mount(
<DeleteUserNavLink user={user} deleteUser={() => {}} />
<DeleteUser user={user} deleteUser={() => {}} />
);
navLink.find("a").simulate("click");
@@ -69,7 +69,7 @@ describe("DeleteUserNavLink", () => {
}
const navLink = mount(
<DeleteUserNavLink
<DeleteUser
user={user}
confirmDialog={false}
deleteUser={capture}

View File

@@ -10,6 +10,7 @@ import {
validation as validator
} from "@scm-manager/ui-components";
import * as userValidator from "./userValidation";
import DeleteUser from "./DeleteUser";
type Props = {
submitForm: User => void,
@@ -153,6 +154,9 @@ class UserForm extends React.Component<Props, State> {
label={t("user-form.submit")}
/>
</div>
<div className="column">
<DeleteUser user={user} />
</div>
</div>
</form>
);

View File

@@ -1,3 +1,2 @@
export { default as DeleteUserNavLink } from "./DeleteUserNavLink";
export { default as EditUserNavLink } from "./EditUserNavLink";
export { default as SetPasswordNavLink } from "./SetPasswordNavLink";

View File

@@ -26,7 +26,6 @@ import {
} from "../modules/users";
import {
DeleteUserNavLink,
EditUserNavLink,
SetPasswordNavLink
} from "./../components/navLinks";