Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-16 02:06:18 +01:00
Code Issues Packages Projects Releases Activity

do not swallow the ScmSecurityException in PermissionFilter

Browse Source
This commit is contained in:
Sebastian Sdorra
2016-05-25 10:03:04 +02:00
parent 56891afae2
commit 71b742388c
1 changed files with 9 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
scm-core/src/main/java/sonia/scm/web/filter/PermissionFilter.java
View File

@@ -160,34 +160,25 @@ public abstract class PermissionFilter extends HttpFilter
boolean writeRequest = isWriteRequest(request); boolean writeRequest = isWriteRequest(request);
if (hasPermission(repository, writeRequest)) if (hasPermission(repository, writeRequest))
{
if (logger.isTraceEnabled())
{ {
logger.trace("{} access to repository {} for user {} granted", logger.trace("{} access to repository {} for user {} granted",
getActionAsString(writeRequest), repository.getName(), getActionAsString(writeRequest), repository.getName(),
getUserName(subject)); getUserName(subject));
}
chain.doFilter(request, response); chain.doFilter(request, response);
} }
else else
{
if (logger.isInfoEnabled())
{ {
logger.info("{} access to repository {} for user {} denied", logger.info("{} access to repository {} for user {} denied",
getActionAsString(writeRequest), repository.getName(), getActionAsString(writeRequest), repository.getName(),
getUserName(subject)); getUserName(subject));
}
sendAccessDenied(request, response, subject); sendAccessDenied(request, response, subject);
} }
} }
else else
{
if (logger.isDebugEnabled())
{ {
logger.debug("repository not found"); logger.debug("repository not found");
}
response.sendError(HttpServletResponse.SC_NOT_FOUND); response.sendError(HttpServletResponse.SC_NOT_FOUND);
} }
@@ -210,12 +201,7 @@ public abstract class PermissionFilter extends HttpFilter
} }
catch (ScmSecurityException ex) catch (ScmSecurityException ex)
{ {
if (logger.isWarnEnabled()) logger.warn("user " + subject.getPrincipal() + " has not enough permissions", ex);
{
logger.warn("user {} has not enough permissions",
subject.getPrincipal());
}
sendAccessDenied(request, response, subject); sendAccessDenied(request, response, subject);
} }