Improve a11y (#1841)

Improve accessibility by removing unnecessary tags without hrefs. Also remove many eslint errors and warnings.

scm-ui/ui-components/src/layout/Footer.stories.tsx

@@ -40,7 +40,7 @@ const trillian: Me = {
   displayName: "Trillian McMillian",
   mail: "tricia@hitchhiker.com",
   groups: ["crew"],
-  _links: {}
+  _links: {},
 };
 
 const bindAvatar = (binder: Binder, avatar: string) => {
@@ -65,7 +65,7 @@ const withBinder = (binder: Binder) => {
 };
 
 storiesOf("Footer", module)
-  .addDecorator(story => <MemoryRouter initialEntries={["/"]}>{story()}</MemoryRouter>)
+  .addDecorator((story) => <MemoryRouter initialEntries={["/"]}>{story()}</MemoryRouter>)
   .add("Default", () => {
     return <Footer me={trillian} version="2.0.0" links={{}} />;
   })

scm-ui/ui-components/src/layout/SecondaryNavigationColumn.tsx

@@ -29,7 +29,7 @@ const SecondaryColumn = styled.div<{ collapsed: boolean }>`
   /* In Bulma there is unfortunately no intermediate step between .is-1 and .is-2, hence the size. 
   Navigation size should be as constant as possible. */
   flex: none;
-  width: ${props => (props.collapsed ? "5.5rem" : "20.5rem")};
+  width: ${(props) => (props.collapsed ? "5.5rem" : "20.5rem")};
   max-width: ${(props: { collapsed: boolean }) => (props.collapsed ? "11.3%" : "25%")};
   /* Render this column to full size if column construct breaks (page size too small). */
   @media (max-width: 785px) {

scm-ui/ui-components/src/layout/Title.tsx

@@ -31,7 +31,7 @@ type Props = {
   className?: string;
 };
 
-const Title: FC<Props> = ({ title, preventRefreshingPageTitle, customPageTitle, className , children}) => {
+const Title: FC<Props> = ({ title, preventRefreshingPageTitle, customPageTitle, className, children }) => {
   useEffect(() => {
     if (!preventRefreshingPageTitle) {
       if (customPageTitle) {
@@ -51,7 +51,7 @@ const Title: FC<Props> = ({ title, preventRefreshingPageTitle, customPageTitle,
 };
 
 Title.defaultProps = {
-  preventRefreshingPageTitle: false
+  preventRefreshingPageTitle: false,
 };
 
 export default Title;