Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-09 06:55:47 +01:00
Code Issues Packages Projects Releases Activity

WIP: Reworking ErrorPage/ErrorNotification

Browse Source
This commit is contained in:
Philipp Czora
2019-02-26 17:08:33 +01:00
parent c67b2c3197
commit 6b55df464c
7 changed files with 159 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
scm-ui-components/packages/ui-components/src/ErrorNotification.js
View File

@@ -1,70 +1,22 @@
//@flow
import React from "react";
import { translate } from "react-i18next";
import Notification from "./Notification";
import { BackendError, UnauthorizedError } from "./errors";
import Notification from "./Notification";
import BackendErrorNotification from "./BackendErrorNotification";
type Props = {
t: string => string,
error?: Error
};
class ErrorNotification extends React.Component<Props> {
renderMoreInformationLink(error: BackendError) {
if (error.url) {
// TODO i18n
return (
<p>
For more information, see{" "}
<a href={error.url} target="_blank">
{error.errorCode}
</a>
</p>
);
}
}
renderBackendError = (error: BackendError) => {
// TODO i18n
// how should we handle i18n for the message?
// we could add translation for known error codes to i18n and pass the context objects as parameters,
// but this will not work for errors from plugins, because the ErrorNotification will search for the translation
// in the wrong namespace (plugins could only add translations to the plugins namespace.
// should we add a special namespace for errors? which could be extend by plugins?
// TODO error page
// we have currently the ErrorNotification, which is often wrapped by the ErrorPage
// the ErrorPage has often a SubTitle like "Unkwown xzy error", which is no longer always the case
// if the error is a BackendError its not fully unknown
return (
<div className="content">
<p>{error.message}</p>
<p>
<strong>Context:</strong>
</p>
<ul>
{error.context.map((context, index) => {
return (
<li key={index}>
<strong>{context.type}:</strong> {context.id}
</li>
);
})}
</ul>
{this.renderMoreInformationLink(error)}
<div className="level is-size-7">
<div className="left">ErrorCode: {error.errorCode}</div>
<div className="right">TransactionId: {error.transactionId}</div>
</div>
</div>
);
};
render() {
const { t, error } = this.props;
if (error) {
if (error instanceof BackendError) {
return this.renderBackendError(error);
return <BackendErrorNotification error={error} />
} else if (error instanceof UnauthorizedError) {
return (
<Notification type="danger">