Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-12 08:25:44 +01:00
Code Issues Packages Projects Releases Activity

fix sonar findings

Browse Source
This commit is contained in:
Eduard Heimbuch
2020-06-30 11:25:36 +02:00
parent f8640d300e
commit 63692d497a
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
scm-core/src/main/java/sonia/scm/repository/ChangeNamespaceNotAllowedException.java
View File

@@ -27,6 +27,7 @@ package sonia.scm.repository;
import sonia.scm.BadRequestException; import sonia.scm.BadRequestException;
import sonia.scm.ContextEntry; import sonia.scm.ContextEntry;
@SuppressWarnings("squid:MaximumInheritanceDepth") // exceptions have a deep inheritance depth themselves; therefore we accept this here
public class ChangeNamespaceNotAllowedException extends BadRequestException { public class ChangeNamespaceNotAllowedException extends BadRequestException {
public ChangeNamespaceNotAllowedException(Repository repository) { public ChangeNamespaceNotAllowedException(Repository repository) {

5
scm-webapp/src/test/java/sonia/scm/repository/DefaultRepositoryManagerTest.java
View File

@@ -217,8 +217,7 @@ public class DefaultRepositoryManagerTest extends ManagerTestBase<Repository> {
// test for reference // test for reference
assertNotSame(heartOfGold, heartReference); assertNotSame(heartOfGold, heartReference);
heartReference.setDescription("prototype ship"); heartReference.setDescription("prototype ship");
assertFalse( assertNotEquals(heartOfGold.getDescription(), heartReference.getDescription());
heartOfGold.getDescription().equals(heartReference.getDescription()));
} }
@Test @Test
@@ -305,7 +304,7 @@ public class DefaultRepositoryManagerTest extends ManagerTestBase<Repository> {
Repository hearReference = manager.get(heartOfGold.getId()); Repository hearReference = manager.get(heartOfGold.getId());
assertNotNull(hearReference); assertNotNull(hearReference);
assertEquals(hearReference.getDescription(), "prototype ship"); assertEquals("prototype ship", hearReference.getDescription());
} }
@Test @Test