From 63692d497a32f3fc24bfd926c99b39ccbe5629c6 Mon Sep 17 00:00:00 2001
From: Eduard Heimbuch <eduard.heimbuch@cloudogu.com>
Date: Tue, 30 Jun 2020 11:25:36 +0200
Subject: [PATCH] fix sonar findings

---
 .../scm/repository/ChangeNamespaceNotAllowedException.java   | 1 +
 .../sonia/scm/repository/DefaultRepositoryManagerTest.java   | 5 ++---
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/scm-core/src/main/java/sonia/scm/repository/ChangeNamespaceNotAllowedException.java b/scm-core/src/main/java/sonia/scm/repository/ChangeNamespaceNotAllowedException.java
index 783761e5ff..a9d4f8a631 100644
--- a/scm-core/src/main/java/sonia/scm/repository/ChangeNamespaceNotAllowedException.java
+++ b/scm-core/src/main/java/sonia/scm/repository/ChangeNamespaceNotAllowedException.java
@@ -27,6 +27,7 @@ package sonia.scm.repository;
 import sonia.scm.BadRequestException;
 import sonia.scm.ContextEntry;
 
+@SuppressWarnings("squid:MaximumInheritanceDepth") // exceptions have a deep inheritance depth themselves; therefore we accept this here
 public class ChangeNamespaceNotAllowedException extends BadRequestException {
 
   public ChangeNamespaceNotAllowedException(Repository repository) {
diff --git a/scm-webapp/src/test/java/sonia/scm/repository/DefaultRepositoryManagerTest.java b/scm-webapp/src/test/java/sonia/scm/repository/DefaultRepositoryManagerTest.java
index 326b1f59e7..26299a04a8 100644
--- a/scm-webapp/src/test/java/sonia/scm/repository/DefaultRepositoryManagerTest.java
+++ b/scm-webapp/src/test/java/sonia/scm/repository/DefaultRepositoryManagerTest.java
@@ -217,8 +217,7 @@ public class DefaultRepositoryManagerTest extends ManagerTestBase<Repository> {
     // test for reference
     assertNotSame(heartOfGold, heartReference);
     heartReference.setDescription("prototype ship");
-    assertFalse(
-      heartOfGold.getDescription().equals(heartReference.getDescription()));
+    assertNotEquals(heartOfGold.getDescription(), heartReference.getDescription());
   }
 
   @Test
@@ -305,7 +304,7 @@ public class DefaultRepositoryManagerTest extends ManagerTestBase<Repository> {
     Repository hearReference = manager.get(heartOfGold.getId());
 
     assertNotNull(hearReference);
-    assertEquals(hearReference.getDescription(), "prototype ship");
+    assertEquals("prototype ship", hearReference.getDescription());
   }
 
   @Test