Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-01 19:15:52 +01:00
Code Issues Packages Projects Releases Activity

fix some code smells reported by SonarQube

Browse Source
This commit is contained in:
Sebastian Sdorra
2019-08-21 16:46:50 +02:00
parent 0ce9aeb400
commit 6351e39c12
3 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
scm-ui/src/admin/plugins/components/InstallPendingAction.js
View File

@@ -1,6 +1,6 @@
// @flow // @flow
import React from "react"; import React from "react";
import { Button, ButtonGroup, Modal } from "@scm-manager/ui-components"; import { Button } from "@scm-manager/ui-components";
import type { PluginCollection } from "@scm-manager/ui-types"; import type { PluginCollection } from "@scm-manager/ui-types";
import { translate } from "react-i18next"; import { translate } from "react-i18next";
import InstallPendingModal from "./InstallPendingModal"; import InstallPendingModal from "./InstallPendingModal";

6
scm-webapp/src/main/java/sonia/scm/api/v2/resources/PluginDtoCollectionMapper.java
View File

@@ -50,10 +50,8 @@ public class PluginDtoCollectionMapper {
Links.Builder linksBuilder = linkingTo() Links.Builder linksBuilder = linkingTo()
.with(Links.linkingTo().self(baseUrl).build()); .with(Links.linkingTo().self(baseUrl).build());
if (PluginPermissions.manage().isPermitted()) { if (PluginPermissions.manage().isPermitted() && containsPending(plugins)) {
if (containsPending(plugins)) { linksBuilder.single(Link.link("installPending", resourceLinks.availablePluginCollection().installPending()));
linksBuilder.single(Link.link("installPending", resourceLinks.availablePluginCollection().installPending()));
}
} }
return linksBuilder.build(); return linksBuilder.build();

1
scm-webapp/src/main/java/sonia/scm/plugin/PluginInstaller.java
View File

@@ -26,6 +26,7 @@ class PluginInstaller {
this.client = client; this.client = client;
} }
@SuppressWarnings("squid:S4790") // hashing should be safe
public PendingPluginInstallation install(AvailablePlugin plugin) { public PendingPluginInstallation install(AvailablePlugin plugin) {
Path file = null; Path file = null;
try (HashingInputStream input = new HashingInputStream(Hashing.sha256(), download(plugin))) { try (HashingInputStream input = new HashingInputStream(Hashing.sha256(), download(plugin))) {