fix some code smells reported by SonarQube

This commit is contained in:
Sebastian Sdorra
2019-08-21 16:46:50 +02:00
parent 0ce9aeb400
commit 6351e39c12
3 changed files with 4 additions and 5 deletions

View File

@@ -50,10 +50,8 @@ public class PluginDtoCollectionMapper {
Links.Builder linksBuilder = linkingTo()
.with(Links.linkingTo().self(baseUrl).build());
if (PluginPermissions.manage().isPermitted()) {
if (containsPending(plugins)) {
linksBuilder.single(Link.link("installPending", resourceLinks.availablePluginCollection().installPending()));
}
if (PluginPermissions.manage().isPermitted() && containsPending(plugins)) {
linksBuilder.single(Link.link("installPending", resourceLinks.availablePluginCollection().installPending()));
}
return linksBuilder.build();