fix potential bugs

This commit is contained in:
Sebastian Sdorra
2010-11-28 10:40:12 +01:00
parent b59345258b
commit 6074293095
10 changed files with 30 additions and 43 deletions

View File

@@ -44,9 +44,6 @@ import org.eclipse.jgit.lib.RepositoryCache;
import org.eclipse.jgit.lib.RepositoryCache.FileKey;
import org.eclipse.jgit.util.FS;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import sonia.scm.repository.GitConfig;
//~--- JDK imports ------------------------------------------------------------
@@ -63,12 +60,6 @@ import javax.servlet.http.HttpServletRequest;
public class GitRepositoryResolver implements RepositoryResolver
{
/** the logger for GitRepositoryResolver */
private static final Logger logger =
LoggerFactory.getLogger(GitRepositoryResolver.class);
//~--- constructors ---------------------------------------------------------
/**
* Constructs ...
*
@@ -171,16 +162,19 @@ public class GitRepositoryResolver implements RepositoryResolver
}
catch (RuntimeException e)
{
repository.close();
throw new RepositoryNotFoundException(repositoryName, e);
}
catch (IOException e)
{
repository.close();
throw new RepositoryNotFoundException(repositoryName, e);
}
finally
{
if (repository != null)
{
repository.close();
}
}
return repository;
}

View File

@@ -41,9 +41,6 @@ import org.eclipse.jgit.lib.PersonIdent;
import org.eclipse.jgit.lib.Repository;
import org.eclipse.jgit.revwalk.RevCommit;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import sonia.scm.io.RegexResourceProcessor;
import sonia.scm.io.ResourceProcessor;
import sonia.scm.util.IOUtil;