Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-15 09:46:16 +01:00
Code Issues Packages Projects Releases Activity

Add comment from previous commit

Browse Source
This commit is contained in:
René Pfeuffer
2019-02-14 11:22:58 +01:00
parent 49e9671fa7
commit 5a5cafaee0
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
scm-plugins/scm-hg-plugin/src/main/java/sonia/scm/repository/HgContextRequestStore.java
View File

@@ -4,6 +4,13 @@ import com.google.inject.servlet.RequestScoped;
/** /**
* Holds an instance of {@link HgContext} in the request scope. * Holds an instance of {@link HgContext} in the request scope.
*
* <p>The problem seems to be that guice had multiple options for injecting HgContext. {@link HgContextProvider}
* bound via Module and {@link HgContext} bound void {@link RequestScoped} annotation. It looks like that Guice 4
* injects randomly the one or the other, in SCMv1 (Guice 3) everything works as expected.</p>
*
* <p>To fix the problem we have created this class annotated with {@link RequestScoped}, which holds an instance
* of {@link HgContext}. This way only the {@link HgContextProvider} is used for injection.</p>
*/ */
@RequestScoped @RequestScoped
public class HgContextRequestStore { public class HgContextRequestStore {