fix some potential bugs

scm-webapp/src/main/java/sonia/scm/BindingExtensionProcessor.java

@@ -208,7 +208,11 @@ public class BindingExtensionProcessor implements ExtensionProcessor
           binder.bind(extensionClass);
         }
       }
-      catch (Exception ex)
+      catch (IllegalAccessException ex)
+      {
+        logger.error(ex.getMessage(), ex);
+      }
+      catch (InstantiationException ex)
       {
         logger.error(ex.getMessage(), ex);
       }

scm-webapp/src/main/java/sonia/scm/api/rest/resources/PluginResource.java

@@ -41,7 +41,6 @@ import com.google.inject.Singleton;
 import sonia.scm.plugin.DefaultPluginManager;
 import sonia.scm.plugin.OverviewPluginFilter;
 import sonia.scm.plugin.PluginInformation;
-import sonia.scm.util.Util;
 
 //~--- JDK imports ------------------------------------------------------------
 

scm-webapp/src/main/java/sonia/scm/group/xml/XmlGroupManager.java

@@ -60,7 +60,6 @@ import java.io.IOException;
 
 import java.util.Collection;
 import java.util.LinkedList;
-import java.util.Set;
 
 /**
  *

scm-webapp/src/main/java/sonia/scm/plugin/AetherPluginHandler.java

@@ -167,8 +167,6 @@ public class AetherPluginHandler
     List<Dependency> dependencies = getInstalledDependencies(null);
 
     collectDependencies(dependency, dependencies);
-
-    
   }
 
   /**
@@ -364,13 +362,10 @@ public class AetherPluginHandler
       {
         String id = plugin.getId();
 
-        if ((skipId == null) ||!id.equals(skipId))
+        if (Util.isNotEmpty(id) && ((skipId == null) ||!id.equals(skipId)))
         {
-          if (Util.isNotEmpty(id))
-          {
-            dependencies.add(new Dependency(new DefaultArtifact(id),
-                                            PLUGIN_SCOPE));
-          }
+          dependencies.add(new Dependency(new DefaultArtifact(id),
+                                          PLUGIN_SCOPE));
         }
       }
     }

scm-webapp/src/main/java/sonia/scm/plugin/OverviewPluginFilter.java

@@ -41,7 +41,8 @@ public class OverviewPluginFilter implements PluginFilter
 {
 
   /** Field description */
-  public static OverviewPluginFilter INSTANCE = new OverviewPluginFilter();
+  public static final OverviewPluginFilter INSTANCE =
+    new OverviewPluginFilter();
 
   //~--- methods --------------------------------------------------------------