Fix endless loading spinner for sources of empty repositories (#1565)

This commit is contained in:
Sebastian Sdorra
2021-03-03 11:00:26 +01:00
committed by GitHub
parent 8e2c2aaa5e
commit 4ec01ff4d1
10 changed files with 200 additions and 24 deletions

View File

@@ -26,7 +26,7 @@ import { Route, useLocation } from "react-router-dom";
import Sources from "../../sources/containers/Sources";
import ChangesetsRoot from "../../containers/ChangesetsRoot";
import { Branch, Repository } from "@scm-manager/ui-types";
import { ErrorPage, Loading } from "@scm-manager/ui-components";
import { ErrorPage, Loading, Notification } from "@scm-manager/ui-components";
import { useTranslation } from "react-i18next";
import { useBranches } from "@scm-manager/ui-api";
@@ -57,7 +57,7 @@ const CodeOverviewWithBranches: FC<Props> = ({ repository, baseUrl }) => {
const { isLoading, error, data } = useBranches(repository);
const selectedBranch = useSelectedBranch();
const [t] = useTranslation("repos");
const branches = data?._embedded.branches;
const branches = data?._embedded.branches || [];
if (isLoading) {
return <Loading />;
@@ -69,6 +69,10 @@ const CodeOverviewWithBranches: FC<Props> = ({ repository, baseUrl }) => {
);
}
if (branches.length === 0) {
return <Notification type="info">{t("code.noBranches")}</Notification>;
}
return <CodeRouting repository={repository} baseUrl={baseUrl} branches={branches} selectedBranch={selectedBranch} />;
};