Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-12-22 00:09:47 +01:00
Code Issues Packages Projects Releases Activity

refactor: replace for loop with foreach

Browse Source
This commit is contained in:
broDom
2017-07-03 16:46:54 +02:00
parent f70745d65a
commit 4bd093f472
2 changed files with 8 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
scm-core/src/main/java/sonia/scm/util/Util.java
View File

@@ -506,12 +506,10 @@ public final class Util
{ {
StringBuilder buffer = new StringBuilder(); StringBuilder buffer = new StringBuilder();
for (int i = 0; i < byteValue.length; i++) for (final byte aByteValue : byteValue) {
{ int x = aByteValue & 0xff;
int x = byteValue[i] & 0xff;
if (x < 16) if (x < 16) {
{
buffer.append('0'); buffer.append('0');
} }

17
scm-plugins/scm-svn-plugin/src/main/java/sonia/scm/web/SvnCollectionRenderer.java
View File

@@ -38,10 +38,8 @@ import com.google.common.collect.ImmutableList.Builder;
import com.google.common.collect.Ordering; import com.google.common.collect.Ordering;
import com.google.inject.Inject; import com.google.inject.Inject;
import com.google.inject.Provider; import com.google.inject.Provider;
import org.slf4j.Logger; import org.slf4j.Logger;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
import org.tmatesoft.svn.core.SVNDirEntry; import org.tmatesoft.svn.core.SVNDirEntry;
import org.tmatesoft.svn.core.SVNErrorMessage; import org.tmatesoft.svn.core.SVNErrorMessage;
import org.tmatesoft.svn.core.SVNException; import org.tmatesoft.svn.core.SVNException;
@@ -50,7 +48,6 @@ import org.tmatesoft.svn.core.internal.server.dav.CollectionRenderer;
import org.tmatesoft.svn.core.internal.server.dav.DAVPathUtil; import org.tmatesoft.svn.core.internal.server.dav.DAVPathUtil;
import org.tmatesoft.svn.core.internal.server.dav.DAVResource; import org.tmatesoft.svn.core.internal.server.dav.DAVResource;
import org.tmatesoft.svn.core.internal.server.dav.DAVResourceURI; import org.tmatesoft.svn.core.internal.server.dav.DAVResourceURI;
import sonia.scm.config.ScmConfiguration; import sonia.scm.config.ScmConfiguration;
import sonia.scm.repository.Repository; import sonia.scm.repository.Repository;
import sonia.scm.repository.RepositoryProvider; import sonia.scm.repository.RepositoryProvider;
@@ -62,14 +59,12 @@ import sonia.scm.url.UrlProvider;
import sonia.scm.url.UrlProviderFactory; import sonia.scm.url.UrlProviderFactory;
import sonia.scm.util.HttpUtil; import sonia.scm.util.HttpUtil;
//~--- JDK imports ------------------------------------------------------------ import javax.servlet.http.HttpServletRequest;
import java.io.IOException; import java.io.IOException;
import java.io.StringWriter; import java.io.StringWriter;
import java.util.Iterator;
import java.util.List; import java.util.List;
import javax.servlet.http.HttpServletRequest;
//~--- JDK imports ------------------------------------------------------------
/** /**
* *
@@ -174,10 +169,8 @@ public class SvnCollectionRenderer implements CollectionRenderer
entries.add(new DirectoryEntry("..", parent, true)); entries.add(new DirectoryEntry("..", parent, true));
} }
for (Iterator iterator = resource.getEntries().iterator(); for (final Object o : resource.getEntries()) {
iterator.hasNext(); ) SVNDirEntry entry = (SVNDirEntry) o;
{
SVNDirEntry entry = (SVNDirEntry) iterator.next();
entries.add(new DirectoryEntry(resource, entry)); entries.add(new DirectoryEntry(resource, entry));
} }