Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2025-11-13 17:05:43 +01:00
Code Issues Packages Projects Releases Activity

Make AvailablePlugin immutable

Browse Source
This commit is contained in:
Rene Pfeuffer
2019-10-02 10:05:07 +02:00
parent 0b68fa1d0c
commit 458d2fb4ee
2 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
scm-core/src/main/java/sonia/scm/plugin/AvailablePlugin.java
View File

@@ -5,7 +5,7 @@ import com.google.common.base.Preconditions;
public class AvailablePlugin implements Plugin { public class AvailablePlugin implements Plugin {
private final AvailablePluginDescriptor pluginDescriptor; private final AvailablePluginDescriptor pluginDescriptor;
private boolean pending; private final boolean pending;
public AvailablePlugin(AvailablePluginDescriptor pluginDescriptor) { public AvailablePlugin(AvailablePluginDescriptor pluginDescriptor) {
this(pluginDescriptor, false); this(pluginDescriptor, false);
@@ -25,10 +25,6 @@ public class AvailablePlugin implements Plugin {
return pending; return pending;
} }
public void cancelInstallation() {
this.pending = false;
}
public AvailablePlugin install() { public AvailablePlugin install() {
Preconditions.checkState(!pending, "installation is already pending"); Preconditions.checkState(!pending, "installation is already pending");
return new AvailablePlugin(pluginDescriptor, true); return new AvailablePlugin(pluginDescriptor, true);

1
scm-webapp/src/main/java/sonia/scm/plugin/PendingPluginInstallation.java
View File

@@ -28,7 +28,6 @@ class PendingPluginInstallation {
LOG.info("cancel installation of plugin {}", name); LOG.info("cancel installation of plugin {}", name);
try { try {
Files.delete(file); Files.delete(file);
plugin.cancelInstallation();
} catch (IOException ex) { } catch (IOException ex) {
throw new PluginFailedToCancelInstallationException("failed to cancel plugin installation ", name, ex); throw new PluginFailedToCancelInstallationException("failed to cancel plugin installation ", name, ex);
} }