fix fetch available verbs and map to state

scm-ui/src/config/containers/GlobalPermissionRoleForm.js

@@ -14,11 +14,10 @@ import {
 import { getRepositoryVerbsLink } from "../../modules/indexResource";
 
 type Props = {
-  submitForm: CustomRoleRequest => void,
   role?: Role,
   loading?: boolean,
+  disabled: boolean,
   availableVerbs: string[],
-  selectedVerbs: string[],
   verbsLink: string,
 
   // context objects
@@ -29,8 +28,7 @@ type Props = {
 };
 
 type State = {
-  role: Role,
+  role: Role
-  verbs: string[]
 };
 
 class GlobalPermissionRoleForm extends React.Component<Props, State> {
@@ -43,8 +41,7 @@ class GlobalPermissionRoleForm extends React.Component<Props, State> {
         verbs: [],
         system: false,
         _links: {}
-      },
+      }
-      verbs: props.availableVerbs
     };
   }
 
@@ -53,7 +50,12 @@ class GlobalPermissionRoleForm extends React.Component<Props, State> {
     fetchAvailableVerbs(verbsLink);
 
     if (role) {
-      this.setState({ role: { ...role } });
+      this.setState({
+        role: {
+          ...role,
+          role: { verbs: role.verbs }
+        }
+      });
     }
   }
 
@@ -80,26 +82,44 @@ class GlobalPermissionRoleForm extends React.Component<Props, State> {
   };
 
   handleVerbChange = (value: boolean, name: string) => {
-    const { selectedVerbs } = this.props;
+    const { role } = this.state;
-    const newVerbs = { ...selectedVerbs, [name]: value };
+
-    this.setState({ verbs: newVerbs });
+    const newVerbs = value
+      ? [...role.verbs, name]
+      : role.verbs.filter(v => v !== name);
+
+    this.setState({
+      ...this.state,
+      role: {
+        ...role,
+        verbs: newVerbs
+      }
+    });
+  };
+
+  submit = (event: Event) => {
+    event.preventDefault();
+    if (this.isValid()) {
+      // this.props.submitForm(this.state.role);
+      //TODO ADD createRole here
+    }
   };
 
   render() {
-    const { loading, availableVerbs, t } = this.props;
+    const { loading, availableVerbs, disabled, t } = this.props;
-    const { role, verbs } = this.state;
+    const { role } = this.state;
 
-    const verbSelectBoxes =
+    const verbSelectBoxes = !availableVerbs
-      !!availableVerbs &&
+      ? null
-      Object.entries(availableVerbs).map(e => (
+      : availableVerbs.map(verb => (
-        <PermissionCheckbox
+          <PermissionCheckbox
-          key={e[0]}
+            key={verb}
-          // disabled={readOnly}
+            // disabled={readOnly}
-          name={e[0]}
+            name={verb}
-          checked={e[1]}
+            checked={role.verbs.includes(verb)}
-          onChange={this.handleVerbChange}
+            onChange={this.handleVerbChange}
-        />
+          />
-      ));
+        ));
 
     return (
       <form onSubmit={this.submit}>
@@ -110,17 +130,18 @@ class GlobalPermissionRoleForm extends React.Component<Props, State> {
               label={t("roles.create.name")}
               onChange={this.handleNameChange}
               value={role.name ? role.name : ""}
-              disabled={!!role.name} // || disabled
+              disabled={!!role.name || disabled}
             />
           </div>
         </div>
         <>{verbSelectBoxes}</>
+        <hr />
         <div className="columns">
           <div className="column">
             <SubmitButton
               loading={loading}
               label={t("roles.create.submit")}
-              //disabled={disabled || !this.isValid()}
+              disabled={disabled || !this.isValid()}
             />
           </div>
         </div>

scm-ui/src/config/modules/roles.js

@@ -220,12 +220,7 @@ function verbReducer(state: any = {}, action: any = {}) {
   switch (action.type) {
     case FETCH_VERBS_SUCCESS:
       const verbs = action.payload.verbs;
-      const verbMap = {};
+      return { ...state, verbs };
-      verbs.forEach(p => (verbMap[p] = false));
-      return {
-        ...state,
-        verbMap
-      };
     default:
       return state;
   }