do not append non valid ClassOverrides

This commit is contained in:
Sebastian Sdorra
2012-03-04 19:46:44 +01:00
parent d7face5091
commit 410ce2fb4d
2 changed files with 28 additions and 2 deletions

View File

@@ -36,6 +36,8 @@ package sonia.scm;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import sonia.scm.util.AssertUtil;
//~--- JDK imports ------------------------------------------------------------
import java.io.IOException;
@@ -157,7 +159,19 @@ public class ClassOverrides implements Iterable<ClassOverride>
*/
public void append(ClassOverrides overrides)
{
getOverrides().addAll(overrides.getOverrides());
AssertUtil.assertIsNotNull(overrides);
for (ClassOverride co : overrides)
{
if (co.isValid())
{
getOverrides().add(co);
}
else if (logger.isWarnEnabled())
{
logger.warn("could not append ClassOverride, because it is not valid");
}
}
}
/**