normalize urls for BaseUrlFilter to prevent redirect loops, see issue #311

This commit is contained in:
Sebastian Sdorra
2013-01-12 12:44:20 +01:00
parent 1f3feca67a
commit 40ce740ae5
4 changed files with 178 additions and 13 deletions

View File

@@ -0,0 +1,67 @@
/**
* Copyright (c) 2010, Sebastian Sdorra All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
*
* 1. Redistributions of source code must retain the above copyright notice,
* this list of conditions and the following disclaimer. 2. Redistributions in
* binary form must reproduce the above copyright notice, this list of
* conditions and the following disclaimer in the documentation and/or other
* materials provided with the distribution. 3. Neither the name of SCM-Manager;
* nor the names of its contributors may be used to endorse or promote products
* derived from this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR
* ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
* http://bitbucket.org/sdorra/scm-manager
*
*/
package sonia.scm.filter;
//~--- non-JDK imports --------------------------------------------------------
import org.junit.Test;
import sonia.scm.config.ScmConfiguration;
import static org.junit.Assert.*;
/**
*
* @author Sebastian Sdorra
*/
public class BaseUrlFilterTest
{
/**
* Method description
*
*/
@Test
public void startsWithTest()
{
BaseUrlFilter filter = new BaseUrlFilter(new ScmConfiguration());
assertTrue(filter.startsWith("http://www.scm-manager.org/scm",
"http://www.scm-manager.org/scm"));
assertTrue(filter.startsWith("http://www.scm-manager.org:80/scm",
"http://www.scm-manager.org/scm"));
assertTrue(filter.startsWith("https://www.scm-manager.org/scm",
"https://www.scm-manager.org:443/scm"));
assertFalse(filter.startsWith("http://www.scm-manager.org/acb",
"http://www.scm-manager.org/scm"));
}
}